Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Disable tracing/release_max_level_off for wasm, too #49639

Merged
merged 5 commits into from
May 15, 2023
Merged

fix: Disable tracing/release_max_level_off for wasm, too #49639

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d5f4f12
Remove
kdy1 May 11, 2023
4e48995
build-wasm
kdy1 May 11, 2023
8cffc9f
Fix CI
kdy1 May 11, 2023
ae8ca14
order
kdy1 May 15, 2023
cf38f1e
Review
kdy1 May 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/build_test_deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1537,7 +1537,7 @@ jobs:
run: node scripts/normalize-version-bump.js

- name: Build
run: turbo run build-wasm -- --target ${{ matrix.target }}
run: turbo run build-wasm -- --target ${{ matrix.target }} --features tracing/release_max_level_info
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a build-wasm-release script and use that?

Copy link
Member Author

@kdy1 kdy1 May 11, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure. Do you prefer it?


- name: Add target to folder name
run: '[[ -d "packages/next-swc/crates/wasm/pkg" ]] && mv packages/next-swc/crates/wasm/pkg packages/next-swc/crates/wasm/pkg-${{ matrix.target }} || ls packages/next-swc/crates/wasm'
Expand Down Expand Up @@ -1602,7 +1602,7 @@ jobs:

- name: Build
if: ${{needs.build.outputs.docsChange == 'nope'}}
run: turbo run build-wasm --cache-dir=".turbo" -- --target nodejs --dev
run: turbo run build-wasm --cache-dir=".turbo" -- --target nodejs --dev --features tracing/release_max_level_info

- name: Add target to folder name
if: ${{needs.build.outputs.docsChange == 'nope'}}
Expand Down
5 changes: 1 addition & 4 deletions packages/next-swc/crates/wasm/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,7 @@ parking_lot_core = "=0.8.0"
path-clean = "0.1"
serde = { version = "1", features = ["derive"] }
serde_json = "1"
tracing = { version = "0.1.37", features = [
"release_max_level_off",
"max_level_off",
] }
tracing = { version = "0.1.37" }
wasm-bindgen = { version = "0.2", features = ["enable-interning"] }
wasm-bindgen-futures = "0.4.8"
getrandom = { version = "0.2.5", optional = true, default-features = false }
Expand Down