-
Notifications
You must be signed in to change notification settings - Fork 26.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(examples): update with-storybook to v7 #49863
Conversation
Socket Security: Pull Request Alerts is failing, most likely due to updates in package.json. It happened for mee too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you share screenshots of a video of this working?
@@ -5,4 +5,4 @@ export default { | |||
component: NextjsImages, | |||
} | |||
|
|||
export const NextjsImagesPage = () => <NextjsImages /> | |||
export const NextjsImagesPage = {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are these all removed?
"@storybook/manager-webpack5": "^6.4.9", | ||
"@storybook/react": "^6.4.9", | ||
"babel-loader": "^8.2.3", | ||
"@storybook/addon-actions": "^7.0.12", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we make sure these are on latest?
Thanks, but this has been addressed already in #50865, so closing this PR! 💚 |
What?
Updating
with-storybook
example to use Storybook v7Why?
Storybook v7 is released and it has zero-config Next.js support.
(and I had a chance to create a minimal repo.)