Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: warning fetch for [object Request] specified #50003

Merged
merged 5 commits into from
May 18, 2023
Merged

fix: warning fetch for [object Request] specified #50003

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b3ce3c7
fix: warning fetch for `[object Request]` specified
styfle May 18, 2023
0ec8449
Improve warnings
styfle May 18, 2023
5f97d15
Merge branch 'canary' into fix-warning-fetch-string
styfle May 18, 2023
731aa99
Merge branch 'canary' into fix-warning-fetch-string
styfle May 18, 2023
a64c653
Add a test
styfle May 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 9 additions & 1 deletion packages/next/src/server/lib/patch-fetch.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,8 +174,16 @@ export function patchFetch({
typeof _cache === 'string' &&
typeof curRevalidate !== 'undefined'
) {
let _url: string
if (input instanceof URL) {
_url = input.href
} else if (input instanceof Request) {
_url = input.url
} else {
_url = input
}
console.warn(
`Warning: fetch for ${input.toString()} specified "cache: ${_cache}" and "revalidate: ${curRevalidate}", only one should be specified.`
`Warning: fetch for ${_url} specified "cache: ${_cache}" and "revalidate: ${curRevalidate}", only one should be specified.`
styfle marked this conversation as resolved.
Show resolved Hide resolved
)
_cache = undefined
}
Expand Down