Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix types of cookies() #50052

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,18 @@ export class ReadonlyRequestCookiesError extends Error {
}
}

export type ReadonlyRequestCookies = Omit<RequestCookies, 'clear' | 'delete'>
// The `cookies()` API is a mix of request and response cookies. For `.get()` methods,
// we want to return the request cookie if it exists. For mutative methods like `.set()`,
// we want to return the response cookie.
export type ReadonlyRequestCookies = Omit<
RequestCookies,
'set' | 'clear' | 'delete'
> &
Pick<ResponseCookies, 'set' | 'delete'>

export class RequestCookiesAdapter {
public static seal(cookies: RequestCookies): ReadonlyRequestCookies {
return new Proxy(cookies, {
return new Proxy(cookies as any, {
get(target, prop, receiver) {
switch (prop) {
case 'clear':
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,14 @@
import { headers, cookies } from 'next/headers'
import { redirect } from 'next/navigation'

export async function setCookieWithMaxAge() {
cookies().set({
name: 'foo',
value: 'bar',
maxAge: 1000,
})
}

export async function getCookie(name) {
return cookies().get(name)
}
Expand Down