Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: edge runtime with next/legacy/image #50343

Merged
merged 6 commits into from
May 26, 2023
Merged

fix: edge runtime with next/legacy/image #50343

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0b04c94
fix: edge runtime with `next/legacy/image`
styfle May 25, 2023
66f0ea5
Add test for legacy image
styfle May 25, 2023
e6fbad0
Merge branch 'canary' into styfle/next-1237-legacy-image-with-edge-ru…
styfle May 25, 2023
1883839
fix test id
styfle May 25, 2023
b702d0f
Fix the tests
styfle May 25, 2023
b7f63cb
Merge branch 'canary' into styfle/next-1237-legacy-image-with-edge-ru…
styfle May 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/next/src/client/legacy/image.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,11 @@ function defaultLoader({
)
}

if (process.env.NODE_ENV !== 'test') {
if (
process.env.NODE_ENV !== 'test' &&
// micromatch isn't compatible with edge runtime
process.env.NEXT_RUNTIME !== 'edge'
) {
// We use dynamic require because this should only error in development
const { hasMatch } = require('../../shared/lib/match-remote-pattern')
if (!hasMatch(config.domains, config.remotePatterns, parsedSrc)) {
Expand Down