Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use undici.Websocket when is possible #50641

Closed
wants to merge 2 commits into from

Conversation

Kikobeats
Copy link
Member

We avoided to use undici.WebSocket because @jawj found a bug in the implementation.

The fix was merged in undici@5.22.1, so we can be back to use it.

undici.WebSocket is preferred over ws because it's more standard strict and a more aligned with production

@ijjk
Copy link
Member

ijjk commented Jun 1, 2023

Allow CI Workflow Run

  • approve CI run for commit: 067fb49

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@Kikobeats Kikobeats requested review from a team as code owners June 1, 2023 13:33
@socket-security
Copy link

New dependency changes detected. Learn more about Socket for GitHub ↗︎


👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

Pull request alert summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues

📊 Modified Dependency Overview:

🚮 Removed packages: undici@5.22.0

@Kikobeats Kikobeats closed this Jun 1, 2023
@Kikobeats
Copy link
Member Author

Closed in favour of #50636

@Kikobeats Kikobeats deleted the websocket branch June 1, 2023 15:16
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 2, 2023
@Kikobeats Kikobeats restored the websocket branch August 16, 2023 13:15
@Kikobeats Kikobeats deleted the websocket branch August 16, 2023 13:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants