Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

next/font: tolerate missing unused fields in capsize map #50708

Merged
merged 1 commit into from
Jun 2, 2023
Merged

next/font: tolerate missing unused fields in capsize map #50708

merged 1 commit into from
Jun 2, 2023

Commits on Jun 2, 2023

  1. next/font: tolerate missing unused fields in capsize map 

    Some font entries in capsize do not include fields like `cap_height` and `x_height`. Since these are unused by next/font, remove these from the serde structure entirely.

Additionally, this makes it so that failing to read or deserialize the capsize map results in an `Error` rather than a `FontFallbackError`, which causes a build failure rather than silently omitting a fallback font. `next/font` should always include this map, and it obscured the real issue here. However, a missing entry in this map _should_ result in omitting a fallback.
    @wbinnssmith
    wbinnssmith committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    b3c030c View commit details
    Browse the repository at this point in the history