Optimize next-app-loader resolving speed

packages/next/src/build/index.ts

@@ -28,7 +28,7 @@ import {
   PAGES_DIR_ALIAS,
   INSTRUMENTATION_HOOK_FILENAME,
 } from '../lib/constants'
-import { fileExists } from '../lib/file-exists'
+import { FileType, fileExists } from '../lib/file-exists'
 import { findPagesDir } from '../lib/find-pages-dir'
 import loadCustomRoutes, {
   CustomRoutes,
@@ -588,7 +588,7 @@ export default async function build(
           for (const page in mappedPages) {
             const hasPublicPageFile = await fileExists(
               path.join(publicDir, page === '/' ? '/index' : page),
-              'file'
+              FileType.File
             )
             if (hasPublicPageFile) {
               conflictingPublicFiles.push(page)

packages/next/src/build/webpack/loaders/metadata/discover.ts

@@ -1,4 +1,3 @@
-import type webpack from 'webpack'
 import type {
   CollectingMetadata,
   PossibleStaticMetadataFileNameConvention,
@@ -7,6 +6,7 @@ import path from 'path'
 import { stringify } from 'querystring'
 import { STATIC_METADATA_IMAGES } from '../../../../lib/metadata/is-metadata-route'
 import { WEBPACK_RESOURCE_QUERIES } from '../../../../lib/constants'
+import { MetadataResolver } from '../next-app-loader'
 
 const METADATA_TYPE = 'metadata'
 
@@ -16,16 +16,14 @@ async function enumMetadataFiles(
   filename: string,
   extensions: readonly string[],
   {
-    resolvePath,
-    loaderContext,
+    metadataResolver,
     // When set to true, possible filename without extension could: icon, icon0, ..., icon9
     numericSuffix,
   }: {
-    resolvePath: (pathname: string) => Promise<string>
-    loaderContext: webpack.LoaderContext<any>
+    metadataResolver: MetadataResolver
     numericSuffix: boolean
   }
-) {
+): Promise<string[]> {
   const collectedFiles: string[] = []
 
   const possibleFileNames = [filename].concat(
@@ -36,19 +34,9 @@ async function enumMetadataFiles(
       : []
   )
   for (const name of possibleFileNames) {
-    for (const ext of extensions) {
-      const pathname = path.join(dir, `${name}.${ext}`)
-      try {
-        const resolved = await resolvePath(pathname)
-        loaderContext.addDependency(resolved)
-
-        collectedFiles.push(resolved)
-      } catch (err: any) {
-        if (!err.message.includes("Can't resolve")) {
-          throw err
-        }
-        loaderContext.addMissingDependency(pathname)
-      }
+    const resolved = await metadataResolver(path.join(dir, name), extensions)
+    if (resolved) {
+      collectedFiles.push(resolved)
     }
   }
 
@@ -59,16 +47,14 @@ export async function createStaticMetadataFromRoute(
   resolvedDir: string,
   {
     segment,
-    resolvePath,
+    metadataResolver,
     isRootLayoutOrRootPage,
-    loaderContext,
     pageExtensions,
     basePath,
   }: {
     segment: string
-    resolvePath: (pathname: string) => Promise<string>
+    metadataResolver: MetadataResolver
     isRootLayoutOrRootPage: boolean
-    loaderContext: webpack.LoaderContext<any>
     pageExtensions: string[]
     basePath: string
   }
@@ -82,11 +68,6 @@ export async function createStaticMetadataFromRoute(
     manifest: undefined,
   }
 
-  const opts = {
-    resolvePath,
-    loaderContext,
-  }
-
   async function collectIconModuleIfExists(
     type: PossibleStaticMetadataFileNameConvention
   ) {
@@ -96,7 +77,7 @@ export async function createStaticMetadataFromRoute(
         resolvedDir,
         'manifest',
         staticManifestExtension.concat(pageExtensions),
-        { ...opts, numericSuffix: false }
+        { metadataResolver, numericSuffix: false }
       )
       if (manifestFile.length > 0) {
         hasStaticMetadataFiles = true
@@ -116,7 +97,7 @@ export async function createStaticMetadataFromRoute(
         ...STATIC_METADATA_IMAGES[type].extensions,
         ...(type === 'favicon' ? [] : pageExtensions),
       ],
-      { ...opts, numericSuffix: true }
+      { metadataResolver, numericSuffix: true }
     )
     resolvedMetadataFiles
       .sort((a, b) => a.localeCompare(b))