Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix esm module import warning for middleware loader #51014

Merged
merged 3 commits into from
Jun 9, 2023
Merged

Fix esm module import warning for middleware loader #51014

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6c8a790
Fix esm module import warning for middleware loader
huozhi Jun 9, 2023
98eb4e5
Merge branch 'canary' into fix/loader-mod-import
kodiakhq[bot] Jun 9, 2023
3e6fa76
Merge branch 'canary' into fix/loader-mod-import
kodiakhq[bot] Jun 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/next/src/build/webpack/loaders/next-middleware-loader.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,9 @@ export default function middlewareLoader(this: any) {
return `
import 'next/dist/esm/server/web/globals'
import { adapter } from 'next/dist/esm/server/web/adapter'
import * as mod from ${stringifiedPagePath}
import * as _mod from ${stringifiedPagePath}

const mod = { ..._mod }
huozhi marked this conversation as resolved.
Show resolved Hide resolved
const handler = mod.middleware || mod.default

if (typeof handler !== 'function') {
Expand Down