Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove skip to renable tsconfig tests #51061

Merged
merged 2 commits into from
Jun 9, 2023
Merged

chore: remove skip to renable tsconfig tests #51061

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ddc0a68
chore: remove skip to renable tsconfig tests
styfle Jun 9, 2023
b8b8397
Merge branch 'canary' into reenable-tsconfig-tests-that-were-skipped
styfle Jun 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 2 additions & 8 deletions test/integration/tsconfig-verifier/test/index.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,10 +298,7 @@ describe('tsconfig.json verifier', () => {
`)
})

// TODO-APP: Re-enable this test. Currently fails with the following message:
// Type error: Layout "app/layout.jsx" does not match the required types of a Next.js Layout.
// Invalid configuration "default":
it.skip('allows you to set node16 moduleResolution mode', async () => {
it('allows you to set node16 moduleResolution mode', async () => {
expect(await exists(tsConfig)).toBe(false)

await writeFile(
Expand Down Expand Up @@ -411,10 +408,7 @@ describe('tsconfig.json verifier', () => {
`)
})

// TODO-APP: Re-enable this test. Currently fails with the following message:
// Type error: Layout "app/layout.jsx" does not match the required types of a Next.js Layout.
// Invalid configuration "default":
it.skip('allows you to set node16 module mode', async () => {
it('allows you to set node16 module mode', async () => {
expect(await exists(tsConfig)).toBe(false)

await writeFile(
Expand Down