Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(eslint): next/script beforeInteractive gives warning on appDir #51148

Merged
merged 13 commits into from
Nov 12, 2023
Merged

fix(eslint): next/script beforeInteractive gives warning on appDir #51148

merged 13 commits into from
Nov 12, 2023

Conversation

devjiwonchoi
Copy link
Contributor

@devjiwonchoi devjiwonchoi commented Jun 12, 2023 •
edited

Issue

The context.getFilename() gets the absolute path of the files, and the if statement to filter /src and /app was not working since #46609.

Expected

Do not show a lint warning if use beforeInteractive inside appDir.

Fixes #46609 #50261

@vercel-spaces vercel-spaces bot requested a review from ijjk June 12, 2023 05:23
@ijjk
Copy link
Member

ijjk commented Jun 12, 2023

Allow CI Workflow Run

  • approve CI run for commit: b1ebcca

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@ijjk
Copy link
Member

ijjk commented Jun 12, 2023 •
edited

Allow CI Workflow Run

  • approve CI run for commit: d0a7b9d

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@devjiwonchoi devjiwonchoi changed the title fix: eslint beforeinteractive not ignore appDir fix: eslint beforeinteractive not ignore appDir - Fixes #46609 Jun 12, 2023
@devjiwonchoi
Copy link
Contributor Author

devjiwonchoi commented Jun 13, 2023 •
edited

@shuding @ijjk Requesting for a review.

@devjiwonchoi devjiwonchoi mentioned this pull request Jun 14, 2023
Merged
@devjiwonchoi @ijjk
chore: modify test
33a43f8 
Co-authored-by: JJ Kasper <jj@jjsweb.site>
@devjiwonchoi devjiwonchoi requested a review from ijjk June 22, 2023 04:52
@devjiwonchoi devjiwonchoi mentioned this pull request Jun 26, 2023
Merged
@ijjk
Copy link
Member

ijjk commented Jun 28, 2023 •
edited

Stats from current PR

Default Build
General
vercel/next.js canary devjiwonchoi/next.js feat/fix-appdir-eslint-beforeinteractive Change
buildDuration 10.5s 10.4s N/A
buildDurationCached 6.1s 6s N/A
nodeModulesSize 199 MB 199 MB ✓
nextStartRea..uration (ms) 399ms 419ms N/A
Client Bundles (main, webpack)
vercel/next.js canary devjiwonchoi/next.js feat/fix-appdir-eslint-beforeinteractive Change
199-HASH.js gzip 29.1 kB 29.1 kB N/A
3f784ff6-HASH.js gzip 53.3 kB 53.3 kB N/A
494.HASH.js gzip 180 B 181 B N/A
framework-HASH.js gzip 45.2 kB 45.2 kB ✓
main-app-HASH.js gzip 241 B 240 B N/A
main-HASH.js gzip 31.7 kB 31.8 kB N/A
webpack-HASH.js gzip 1.7 kB 1.7 kB ✓
Overall change 46.9 kB 46.9 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary devjiwonchoi/next.js feat/fix-appdir-eslint-beforeinteractive Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary devjiwonchoi/next.js feat/fix-appdir-eslint-beforeinteractive Change
_app-HASH.js gzip 194 B 195 B N/A
_error-HASH.js gzip 182 B 181 B N/A
amp-HASH.js gzip 504 B 506 B N/A
css-HASH.js gzip 322 B 323 B N/A
dynamic-HASH.js gzip 2.5 kB 2.5 kB ✓
edge-ssr-HASH.js gzip 253 B 255 B N/A
head-HASH.js gzip 348 B 347 B N/A
hooks-HASH.js gzip 369 B 368 B N/A
image-HASH.js gzip 4.3 kB 4.3 kB N/A
index-HASH.js gzip 256 B 256 B ✓
link-HASH.js gzip 2.65 kB 2.65 kB N/A
routerDirect..HASH.js gzip 311 B 311 B ✓
script-HASH.js gzip 384 B 383 B N/A
withRouter-HASH.js gzip 307 B 308 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Overall change 3.17 kB 3.17 kB ✓
Client Build Manifests
vercel/next.js canary devjiwonchoi/next.js feat/fix-appdir-eslint-beforeinteractive Change
_buildManifest.js gzip 486 B 484 B N/A
Overall change 0 B 0 B ✓
Rendered Page Sizes
vercel/next.js canary devjiwonchoi/next.js feat/fix-appdir-eslint-beforeinteractive Change
index.html gzip 527 B 528 B N/A
link.html gzip 541 B 543 B N/A
withRouter.html gzip 524 B 523 B N/A
Overall change 0 B 0 B ✓
Edge SSR bundle Size
vercel/next.js canary devjiwonchoi/next.js feat/fix-appdir-eslint-beforeinteractive Change
edge-ssr.js gzip 92.5 kB 92.5 kB N/A
page.js gzip 145 kB 145 kB N/A
Overall change 0 B 0 B ✓
Middleware size
vercel/next.js canary devjiwonchoi/next.js feat/fix-appdir-eslint-beforeinteractive Change
middleware-b..fest.js gzip 625 B 626 B N/A
middleware-r..fest.js gzip 150 B 151 B N/A
middleware.js gzip 24.8 kB 24.8 kB ✓
edge-runtime..pack.js gzip 1.92 kB 1.92 kB ✓
Overall change 26.7 kB 26.7 kB ✓
Next Runtimes
vercel/next.js canary devjiwonchoi/next.js feat/fix-appdir-eslint-beforeinteractive Change
app-page-exp...dev.js gzip 167 kB 167 kB ✓
app-page-exp..prod.js gzip 93.2 kB 93.2 kB ✓
app-page-tur..prod.js gzip 93.9 kB 93.9 kB ✓
app-page-tur..prod.js gzip 88.5 kB 88.5 kB ✓
app-page.run...dev.js gzip 137 kB 137 kB ✓
app-page.run..prod.js gzip 87.9 kB 87.9 kB ✓
app-route-ex...dev.js gzip 23.8 kB 23.8 kB ✓
app-route-ex..prod.js gzip 16.4 kB 16.4 kB ✓
app-route-tu..prod.js gzip 16.4 kB 16.4 kB ✓
app-route-tu..prod.js gzip 16 kB 16 kB ✓
app-route.ru...dev.js gzip 23.2 kB 23.2 kB ✓
app-route.ru..prod.js gzip 16 kB 16 kB ✓
pages-api-tu..prod.js gzip 9.37 kB 9.37 kB ✓
pages-api.ru...dev.js gzip 9.64 kB 9.64 kB ✓
pages-api.ru..prod.js gzip 9.37 kB 9.37 kB ✓
pages-turbo...prod.js gzip 21.8 kB 21.8 kB ✓
pages.runtim...dev.js gzip 22.5 kB 22.5 kB ✓
pages.runtim..prod.js gzip 21.8 kB 21.8 kB ✓
server.runti..prod.js gzip 48.8 kB 48.8 kB ✓
Overall change 922 kB 922 kB ✓
Commit: 22a9e20

devjiwonchoi and others added 2 commits July 5, 2023 13:00
@devjiwonchoi
improve getting root dir path
d481a7d
@devjiwonchoi @ijjk
refactor managing pathname
b90d397 
- Moved removing root dir path from pathname as `removeProjectRootPath`
- Added `any` type to node
- Use consistent variable name `pathname`
- Added `/` after `src` and `app` to inform it is checking for a path

Co-authored-by: JJ Kasper <jj@jjsweb.site>
@timneutkens timneutkens changed the title fix: eslint beforeinteractive not ignore appDir - Fixes #46609 fix: eslint beforeinteractive not ignore appDir Jul 6, 2023
@devjiwonchoi @timneutkens
fix: add path.sep in front of app/
7db3c43 
Co-authored-by: Tim Neutkens <timneutkens@me.com>
@devjiwonchoi devjiwonchoi changed the title fix: eslint beforeinteractive not ignore appDir fix: eslint for beforeInteractive is not being ignored in /app Jul 12, 2023
@devjiwonchoi devjiwonchoi changed the title fix: eslint for beforeInteractive is not being ignored in /app fix(eslint): next/script beforeInteractive gives warning on appDir Nov 4, 2023
@devjiwonchoi
Copy link
Contributor Author

@ijjk @timneutkens @shuding It's been a while, can we merge this?

timneutkens
timneutkens approved these changes Nov 12, 2023
View reviewed changes
Copy link
Member

@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@timneutkens timneutkens added the CI approved Approve running CI for fork label Nov 12, 2023
@devjiwonchoi
Copy link
Contributor Author

@timneutkens Thank you!! Also, I've initiated next.config.ts and would be so grateful if you'd share your thoughts on #57656

@kodiakhq kodiakhq bot merged commit 022cb25 into vercel:canary Nov 12, 2023
53 of 58 checks passed
@devjiwonchoi devjiwonchoi deleted the feat/fix-appdir-eslint-beforeinteractive branch November 12, 2023 09:34
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

@ijjk ijjk Awaiting requested review from ijjk ijjk is a code owner

@shuding shuding Awaiting requested review from shuding shuding is a code owner

@huozhi huozhi Awaiting requested review from huozhi huozhi is a code owner

@feedthejim feedthejim Awaiting requested review from feedthejim feedthejim is a code owner

@ztanner ztanner Awaiting requested review from ztanner ztanner is a code owner

@wyattjoh wyattjoh Awaiting requested review from wyattjoh wyattjoh is a code owner

Assignees
No one assigned
Labels
CI approved Approve running CI for fork locked type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@devjiwonchoi @ijjk @timneutkens @shuding