Except favicon.ico segment when favicon.ico does not exist #51470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongwonnn
force-pushed
the
except-favicon-segment
branch
4 times, most recently
from
adcaeea
to
e405cd1
Compare
dongwonnn
force-pushed
the
except-favicon-segment
branch
from
e405cd1
to
2c82425
Compare
|
@timneutkens Requesting for a review please. |
dongwonnn
requested review from
timneutkens,
ijjk,
shuding and
feedthejim
as code owners
|
Is this PR outdated? |
Unfortunately, yes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
If the first path of the website starts with a dynamic router (e.g., like app-dir-i18n-routing example) and there is no favicon.ico, prevent the browser-provided favicon.ico from being captured as a segment.
Add a case for dynamic routers to #50795
Why?
In the app-dir-i18n-routing example, an error occurs when "favicon.ico" is stored in [lang] and passed to the getDictionary function. An error log is captured and unnecessary pages are rendered.
I want the favicon.ico to not be captured as a segment and to have the same behavior as #50795.
How?
Added the case where the pathnamame is favicon.ico to skipDynamic option.
Fixes #46918