Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'acorn' dependency #6193

Merged
merged 1 commit into from
Feb 3, 2019
Merged

Conversation

grushetsky
Copy link
Contributor

The dependency was added as a workaround for npm bug (mentioned here). It looks like it should rather be added by the project that uses Next.js. acorn is not used directly by Next.js.

Fixes #6189.

@grushetsky
Copy link
Contributor Author

@timneutkens, how could coverage decrease by removing this package?

@timneutkens timneutkens merged commit 2f304bd into vercel:canary Feb 3, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Feb 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove acorn from deps
2 participants