Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync types of NextNodeServer and BaseServer #62694

Open
wants to merge 1 commit into
base: canary
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/next/src/server/base-server.ts
Expand Up @@ -280,7 +280,7 @@ export class WrappedBuildError extends Error {
type ResponsePayload = {
type: 'html' | 'json' | 'rsc'
body: RenderResult
revalidate?: Revalidate
revalidate?: Revalidate | undefined
}

export type NextEnabledDirectories = {
Expand Down
6 changes: 3 additions & 3 deletions packages/next/src/server/next-server.ts
Expand Up @@ -466,11 +466,11 @@ export default class NextNodeServer extends BaseServer<
res: NodeNextResponse,
options: {
result: RenderResult
type: 'html' | 'json'
type: 'html' | 'json' | 'rsc'
generateEtags: boolean
poweredByHeader: boolean
revalidate: Revalidate | undefined
swrDelta: SwrDelta | undefined
revalidate?: Revalidate | undefined
swrDelta?: SwrDelta | undefined
}
): Promise<void> {
return sendRenderResult({
Expand Down