Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Fix client boundary inheritance for barrel optimization" #64484

Closed
wants to merge 1 commit into from
Closed

Revert "Fix client boundary inheritance for barrel optimization" #64484

wants to merge 1 commit into from

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Apr 15, 2024 •
edited by padmaia

Reverts #64467

testing ci failures

Closes NEXT-3106

@linear Linear
Copy link

linear bot commented Apr 15, 2024

Issue reopened: NEXT-3101 v14.2 causing build error for Material UI

@ijjk
Copy link
Member

ijjk commented Apr 15, 2024 •
edited

Failing test suites

Commit: bef43f6

TURBOPACK=1 pnpm test test/integration/create-next-app/templates/app.test.ts (turbopack)

  • create-next-app --app (App Router) > should create JavaScript project with --js flag
  • create-next-app --app (App Router) > should create TypeScript project with --ts flag
  • create-next-app --app (App Router) > should create project inside "src" directory with --src-dir flag
  • create-next-app --app (App Router) > should create TailwindCSS project with --tailwind flag
Expand output

● create-next-app --app (App Router) › should create JavaScript project with --js flag

FetchError: request to http://localhost:34345/ failed, reason: connect ECONNREFUSED 127.0.0.1:34345

  at ClientRequest.<anonymous> (../node_modules/.pnpm/node-fetch@2.6.7/node_modules/node-fetch/lib/index.js:1491:11)

● create-next-app --app (App Router) › should create TypeScript project with --ts flag

FetchError: request to http://localhost:45379/ failed, reason: connect ECONNREFUSED 127.0.0.1:45379

  at ClientRequest.<anonymous> (../node_modules/.pnpm/node-fetch@2.6.7/node_modules/node-fetch/lib/index.js:1491:11)

● create-next-app --app (App Router) › should create project inside "src" directory with --src-dir flag

FetchError: request to http://localhost:33165/ failed, reason: connect ECONNREFUSED 127.0.0.1:33165

  at ClientRequest.<anonymous> (../node_modules/.pnpm/node-fetch@2.6.7/node_modules/node-fetch/lib/index.js:1491:11)

● create-next-app --app (App Router) › should create TailwindCSS project with --tailwind flag

FetchError: request to http://localhost:38805/ failed, reason: connect ECONNREFUSED 127.0.0.1:38805

  at ClientRequest.<anonymous> (../node_modules/.pnpm/node-fetch@2.6.7/node_modules/node-fetch/lib/index.js:1491:11)

Read more about building and testing Next.js in contributing.md.

TURBOPACK=1 pnpm test test/integration/create-next-app/templates/pages.test.ts (turbopack)

  • create-next-app --no-app (Pages Router) > should create JavaScript project with --js flag
  • create-next-app --no-app (Pages Router) > should create TypeScript project with --ts flag
  • create-next-app --no-app (Pages Router) > should create project inside "src" directory with --src-dir flag
  • create-next-app --no-app (Pages Router) > should create TailwindCSS project with --tailwind flag
Expand output

● create-next-app --no-app (Pages Router) › should create JavaScript project with --js flag

FetchError: request to http://localhost:36631/ failed, reason: connect ECONNREFUSED 127.0.0.1:36631

  at ClientRequest.<anonymous> (../node_modules/.pnpm/node-fetch@2.6.7/node_modules/node-fetch/lib/index.js:1491:11)

● create-next-app --no-app (Pages Router) › should create TypeScript project with --ts flag

FetchError: request to http://localhost:37759/ failed, reason: connect ECONNREFUSED 127.0.0.1:37759

  at ClientRequest.<anonymous> (../node_modules/.pnpm/node-fetch@2.6.7/node_modules/node-fetch/lib/index.js:1491:11)

● create-next-app --no-app (Pages Router) › should create project inside "src" directory with --src-dir flag

FetchError: request to http://localhost:45049/ failed, reason: connect ECONNREFUSED 127.0.0.1:45049

  at ClientRequest.<anonymous> (../node_modules/.pnpm/node-fetch@2.6.7/node_modules/node-fetch/lib/index.js:1491:11)

● create-next-app --no-app (Pages Router) › should create TailwindCSS project with --tailwind flag

FetchError: request to http://localhost:45615/ failed, reason: connect ECONNREFUSED 127.0.0.1:45615

  at ClientRequest.<anonymous> (../node_modules/.pnpm/node-fetch@2.6.7/node_modules/node-fetch/lib/index.js:1491:11)

Read more about building and testing Next.js in contributing.md.

@ijjk
Copy link
Member

ijjk commented Apr 15, 2024

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js revert-64467-fix/barrel-optimization-inherit Change
buildDuration 14.3s 14.2s N/A
buildDurationCached 7.8s 6.5s N/A
nodeModulesSize 199 MB 199 MB N/A
nextStartRea..uration (ms) 406ms 387ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js revert-64467-fix/barrel-optimization-inherit Change
2453-HASH.js gzip 31.4 kB 31.4 kB N/A
3304.HASH.js gzip 181 B 181 B ✓
3f784ff6-HASH.js gzip 53.7 kB 53.7 kB ✓
8299-HASH.js gzip 5.1 kB 5.1 kB N/A
framework-HASH.js gzip 45.2 kB 45.2 kB ✓
main-app-HASH.js gzip 242 B 242 B ✓
main-HASH.js gzip 32.2 kB 32.2 kB N/A
webpack-HASH.js gzip 1.68 kB 1.68 kB N/A
Overall change 99.3 kB 99.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js revert-64467-fix/barrel-optimization-inherit Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary vercel/next.js revert-64467-fix/barrel-optimization-inherit Change
_app-HASH.js gzip 196 B 197 B N/A
_error-HASH.js gzip 184 B 184 B ✓
amp-HASH.js gzip 505 B 505 B ✓
css-HASH.js gzip 324 B 325 B N/A
dynamic-HASH.js gzip 2.5 kB 2.5 kB N/A
edge-ssr-HASH.js gzip 258 B 258 B ✓
head-HASH.js gzip 352 B 352 B ✓
hooks-HASH.js gzip 370 B 371 B N/A
image-HASH.js gzip 4.27 kB 4.27 kB ✓
index-HASH.js gzip 259 B 259 B ✓
link-HASH.js gzip 2.67 kB 2.67 kB N/A
routerDirect..HASH.js gzip 314 B 312 B N/A
script-HASH.js gzip 386 B 386 B ✓
withRouter-HASH.js gzip 309 B 309 B ✓
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Overall change 6.63 kB 6.63 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js revert-64467-fix/barrel-optimization-inherit Change
_buildManifest.js gzip 483 B 485 B N/A
Overall change 0 B 0 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js revert-64467-fix/barrel-optimization-inherit Change
index.html gzip 527 B 529 B N/A
link.html gzip 538 B 541 B N/A
withRouter.html gzip 521 B 523 B N/A
Overall change 0 B 0 B ✓
Edge SSR bundle Size
vercel/next.js canary vercel/next.js revert-64467-fix/barrel-optimization-inherit Change
edge-ssr.js gzip 95.6 kB 95.6 kB N/A
page.js gzip 3.06 kB 3.06 kB N/A
Overall change 0 B 0 B ✓
Middleware size
vercel/next.js canary vercel/next.js revert-64467-fix/barrel-optimization-inherit Change
middleware-b..fest.js gzip 622 B 625 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 25.5 kB 25.5 kB N/A
edge-runtime..pack.js gzip 839 B 839 B ✓
Overall change 839 B 839 B ✓
Next Runtimes
vercel/next.js canary vercel/next.js revert-64467-fix/barrel-optimization-inherit Change
app-page-exp...dev.js gzip 171 kB 171 kB ✓
app-page-exp..prod.js gzip 97.5 kB 97.5 kB ✓
app-page-tur..prod.js gzip 99.2 kB 99.2 kB ✓
app-page-tur..prod.js gzip 93.5 kB 93.5 kB ✓
app-page.run...dev.js gzip 145 kB 145 kB ✓
app-page.run..prod.js gzip 92 kB 92 kB ✓
app-route-ex...dev.js gzip 21.5 kB 21.5 kB ✓
app-route-ex..prod.js gzip 15.2 kB 15.2 kB ✓
app-route-tu..prod.js gzip 15.2 kB 15.2 kB ✓
app-route-tu..prod.js gzip 14.9 kB 14.9 kB ✓
app-route.ru...dev.js gzip 21.1 kB 21.1 kB ✓
app-route.ru..prod.js gzip 14.9 kB 14.9 kB ✓
pages-api-tu..prod.js gzip 9.55 kB 9.55 kB ✓
pages-api.ru...dev.js gzip 9.82 kB 9.82 kB ✓
pages-api.ru..prod.js gzip 9.55 kB 9.55 kB ✓
pages-turbo...prod.js gzip 22.5 kB 22.5 kB ✓
pages.runtim...dev.js gzip 23.1 kB 23.1 kB ✓
pages.runtim..prod.js gzip 22.5 kB 22.5 kB ✓
server.runti..prod.js gzip 51.3 kB 51.3 kB ✓
Overall change 948 kB 948 kB ✓
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js revert-64467-fix/barrel-optimization-inherit Change
0.pack gzip 1.59 MB 1.58 MB N/A
index.pack gzip 107 kB 107 kB ⚠️ +254 B
Overall change 107 kB 107 kB ⚠️ +254 B
Diff details
Diff for middleware.js

Diff too large to display

Commit: bef43f6

@huozhi huozhi closed this Apr 15, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens will be requested when the pull request is marked ready for review timneutkens is a code owner

@ijjk ijjk Awaiting requested review from ijjk ijjk will be requested when the pull request is marked ready for review ijjk is a code owner

@shuding shuding Awaiting requested review from shuding shuding will be requested when the pull request is marked ready for review shuding is a code owner

@ztanner ztanner Awaiting requested review from ztanner ztanner will be requested when the pull request is marked ready for review ztanner is a code owner

@feedthejim feedthejim Awaiting requested review from feedthejim feedthejim will be requested when the pull request is marked ready for review feedthejim is a code owner

@wyattjoh wyattjoh Awaiting requested review from wyattjoh wyattjoh will be requested when the pull request is marked ready for review wyattjoh is a code owner

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team locked type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@huozhi @ijjk