Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update pnpm@9.0.5 #64854

Closed

Conversation

ryota-murakami
Copy link
Contributor

Here are the release notes for PNPM from v9.0.0 to v9.0.5:
Notable change of v9 is Corepack enable by default.
So we can ensure all package manage/resolved exact same version of pnpm.

  • v9.0.0: Discontinued support for Node.js v16 and introduced Corepack compatibility checks. New configuration updates include enabling dedupe-injected-deps and changing the lockfile to version 9, with better readability and resistance to Git conflicts.

  • v9.0.1: Resolved issues with pnpm install --frozen-lockfile, allowing it to work with lockfiles generated by PNPM v8 if no updates are required.

  • v9.0.2: Addressed a bug where optional dependencies were not linked into dependent's node_modules. Fixed some other minor bugs.

  • v9.0.3: Implemented changes to address the script-shell option erroring on Windows with .bat or .cmd files. Also fixed issues with package-manager-strict checks and added more completion command support.

  • v9.0.4: Fixed aliased dependencies resolution on repeated installs with existing lockfiles and addressed issues with engines.pnpm field in package.json being ignored

  • v9.0.5

@ryota-murakami ryota-murakami requested review from manovotny and leerob and removed request for a team April 22, 2024 04:00
@ijjk ijjk added the tests label Apr 22, 2024
@ijjk
Copy link
Member

ijjk commented Apr 22, 2024

Allow CI Workflow Run

  • approve CI run for commit: 4bf847e

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

2 similar comments
@ijjk
Copy link
Member

ijjk commented Apr 22, 2024

Allow CI Workflow Run

  • approve CI run for commit: 4bf847e

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@ijjk
Copy link
Member

ijjk commented Apr 22, 2024

Allow CI Workflow Run

  • approve CI run for commit: 4bf847e

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@babel/code-frame@7.24.2 environment +6 108 kB nicolo-ribaudo
npm/@babel/plugin-syntax-import-assertions@7.24.1 None +1 15.3 kB nicolo-ribaudo
npm/@babel/plugin-syntax-jsx@7.24.1 None +1 15.8 kB nicolo-ribaudo
npm/@babel/preset-env@7.24.4 environment, filesystem Transitive: shell, unsafe +90 4.96 MB nicolo-ribaudo
npm/@babel/runtime@7.24.4 None 0 262 kB nicolo-ribaudo
npm/@babel/traverse@7.24.1 Transitive: environment +11 3.06 MB nicolo-ribaudo
npm/@babel/types@7.24.0 environment +2 2.45 MB nicolo-ribaudo
npm/@playwright/test@1.43.1 Transitive: environment, eval, filesystem, network, shell, unsafe +3 10.3 MB yurys
npm/@rushstack/eslint-patch@1.10.2 None 0 240 kB odspnpm
npm/@types/babel__core@7.20.5 None 0 33 kB types
npm/@types/babel__generator@7.6.8 None 0 11.4 kB types
npm/@types/babel__template@7.4.4 None 0 6.41 kB types
npm/@types/babel__traverse@7.20.5 None 0 84.1 kB types
npm/@types/debug@4.1.12 None +1 9.65 kB types
npm/@types/jsonwebtoken@9.0.6 None 0 13.5 kB types
npm/@types/semver@7.5.8 None 0 23.3 kB types
npm/async-retry@1.3.3 None 0 5.21 kB leerobinson
npm/browserslist@4.23.0 environment, filesystem Transitive: shell +4 408 kB ai
npm/ci-info@3.9.0 environment 0 26.1 kB sibiraj-s
npm/content-type@1.0.5 None 0 10.5 kB dougwilson
npm/eslint-import-resolver-typescript@3.6.1 Transitive: environment, filesystem, unsafe +13 616 kB jounqin
npm/eslint-plugin-jsx-a11y@6.8.0 Transitive: eval +95 7.4 MB ljharb
npm/fast-glob@3.3.2 filesystem +12 346 kB mrmlnc
npm/jsonwebtoken@9.0.2 None +6 122 kB charlesrea
npm/kleur@4.1.5 None 0 20.3 kB lukeed
npm/moment@2.30.1 None 0 4.35 MB ichernev
npm/nanoid@3.3.7 None 0 24.4 kB ai
npm/next@14.2.2 environment, filesystem, network, shell, unsafe Transitive: eval +207 1.22 GB vercel-release-bot
npm/path-to-regexp@6.2.2 None 0 108 kB blakeembrey
npm/punycode@2.3.1 None 0 33.5 kB google-wombot
npm/regenerator-runtime@0.14.1 None 0 27.9 kB benjamn
npm/swr@2.2.5 Transitive: environment +1 658 kB vercel-release-bot
npm/tar@6.2.1 environment, filesystem +7 355 kB isaacs
npm/ua-parser-js@1.0.37 None 0 112 kB faisalman
npm/watchpack@2.4.1 environment, filesystem +1 74.3 kB evilebottnawi

🚮 Removed packages: npm/acorn@8.5.0, npm/arg@4.1.0, npm/asciichart@1.5.25, npm/async-retry@1.3.1, npm/async-sema@3.0.0, npm/bytes@3.1.1, npm/caniuse-lite@1.0.30001579, npm/cheerio@1.0.0-rc.9, npm/commander@2.20.0, npm/content-type@1.0.4, npm/cross-env@7.0.3, npm/debug@4.1.1, npm/dotenv@10.0.0, npm/downsample-lttb@0.0.1, npm/eslint-import-resolver-node@0.3.6, npm/eslint-import-resolver-typescript@3.5.2, npm/eslint-plugin-import@2.28.1, npm/eslint-plugin-jsx-a11y@6.7.1, npm/eslint-plugin-react-hooks@4.5.0, npm/eslint@7.24.0, npm/eslint@8.31.0, npm/execa@4.0.3, npm/fast-glob@3.3.1, npm/fs-extra@10.0.0, npm/glob@10.3.10, npm/glob@7.1.7, npm/globby@11.0.1, npm/image-size@1.0.0, npm/is-docker@2.0.0, npm/jsonwebtoken@9.0.0, npm/kleur@4.1.3, npm/listr2@5.0.8, npm/meow@7.0.1, npm/moment@2.24.0, npm/nanoid@3.1.32, npm/neo-async@2.6.1, npm/next@14.2.1, npm/ora@4.0.4, npm/p-queue@7.3.0, npm/path-to-regexp@6.1.0, npm/picomatch@4.0.1, npm/prettier@2.5.1, npm/punycode@2.1.1, npm/raw-body@2.4.1, npm/recursive-copy@2.0.11, npm/semver@7.3.2, npm/source-map@0.7.3, npm/string_decoder@1.3.0, npm/superstruct@1.0.3, npm/swr@2.2.4, npm/tar@6.1.15, npm/term-size@3.0.2, npm/terser-webpack-plugin@5.3.9, npm/terser@5.27.0, npm/typescript@4.8.2, npm/ua-parser-js@1.0.35, npm/update-check@1.5.4, npm/watchpack@2.4.0, npm/webpack-bundle-analyzer@4.10.1, npm/webpack-bundle-analyzer@4.6.1, npm/webpack-stats-plugin@1.1.0

View full report↗︎

Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSource
Install scripts npm/es5-ext@0.10.64
  • Install script: postinstall
  • Source: node -e "try{require('./_postinstall')}catch(e){}" || exit 0

View full report↗︎

Next steps

What is an install script?

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/es5-ext@0.10.64

@samcx
Copy link
Member

samcx commented Apr 23, 2024

@ryota-murakami Looks like there is a conflict with the lock file :blob_bowing:

@ryota-murakami
Copy link
Contributor Author

@samcx Yeah, but got  ERR_PNPM_FETCH_404  GET https://registry.npmjs.org/@next%2Fswc: Not Found - 404 after merge canary branch.
The package use to other registry?

Screenshot 2024-04-23 at 9 31 14

@samcx
Copy link
Member

samcx commented Apr 23, 2024

@ryota-murakami I just created a new :pr: since it seems that @next/swc is not a registered package, so creating a new lock file was not possible. → #64945

@samcx samcx closed this Apr 23, 2024
@github-actions github-actions bot added the locked label May 9, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants