Fix passing of "allowNamespaces" in @babel/preset-typescrip #8849

Zmingg · 2019-09-25T07:45:33Z

Allow setting 'allowNamespaces' in typescript preset:
babel/babel#10382

Zmingg · 2019-09-25T08:34:32Z

Fix: passing of "allowNamespaces" in @babel/preset-typescript
babel/babel#10383

ijjk · 2019-10-14T13:23:17Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	Zmingg/next.js canary	Change
buildDuration	15s	14.8s	-278ms
nodeModulesSize	48.5 MB	48.5 MB	⚠️ +224 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	Zmingg/next.js canary	Change
main-HASH.js	18.9 kB	18.9 kB	✓
main-HASH.js gzip	6.79 kB	6.79 kB	✓
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..9dda6167a.js	21.9 kB	21.9 kB	✓
4952ddcd88e7..167a.js gzip	7.81 kB	7.81 kB	✓
de003c3a9d30..3a0560775.js	43.2 kB	43.2 kB	✓
de003c3a9d30..0775.js gzip	15.5 kB	15.5 kB	✓
framework.5b..dbaff70d3.js	125 kB	125 kB	✓
framework.5b..70d3.js gzip	39.4 kB	39.4 kB	✓
Overall change	211 kB	211 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	Zmingg/next.js canary	Change
main-HASH.module.js	17.2 kB	17.2 kB	✓
main-HASH.module.js gzip	6.52 kB	6.52 kB	✓
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..72.module.js	45.6 kB	45.6 kB	✓
de003c3a9d30..dule.js gzip	16.5 kB	16.5 kB	✓
framework.5b..d3.module.js	125 kB	125 kB	✓
framework.5b..dule.js gzip	39.4 kB	39.4 kB	✓
Overall change	190 kB	190 kB	✓

Client Pages

	zeit/next.js canary	Zmingg/next.js canary	Change
_app.js	1.81 kB	1.81 kB	✓
_app.js gzip	873 B	873 B	✓
_error.js	12 kB	12 kB	✓
_error.js gzip	4.73 kB	4.73 kB	✓
hooks.js	12.7 kB	12.7 kB	✓
hooks.js gzip	4.79 kB	4.79 kB	✓
index.js	318 B	318 B	✓
index.js gzip	222 B	222 B	✓
link.js	8.14 kB	8.14 kB	✓
link.js gzip	3.5 kB	3.5 kB	✓
routerDirect.js	408 B	408 B	✓
routerDirect.js gzip	281 B	281 B	✓
withRouter.js	419 B	419 B	✓
withRouter.js gzip	280 B	280 B	✓
Overall change	35.8 kB	35.8 kB	✓

Client Pages Modern

	zeit/next.js canary	Zmingg/next.js canary	Change
_app.module.js	1.7 kB	1.7 kB	✓
_app.module.js gzip	832 B	832 B	✓
_error.module.js	23.3 kB	23.3 kB	✓
_error.module.js gzip	8.59 kB	8.59 kB	✓
hooks.module.js	1.52 kB	1.52 kB	✓
hooks.module.js gzip	793 B	793 B	✓
index.module.js	294 B	294 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js	8.53 kB	8.53 kB	✓
link.module.js gzip	3.68 kB	3.68 kB	✓
routerDirect.module.js	394 B	394 B	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.module.js	404 B	404 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	36.1 kB	36.1 kB	✓

Client Build Manifests

	zeit/next.js canary	Zmingg/next.js canary	Change
_buildManifest.js	81 B	81 B	✓
_buildManifest.js gzip	61 B	61 B	✓
_buildManifest.module.js	81 B	81 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	162 B	162 B	✓

Rendered Page Sizes

	zeit/next.js canary	Zmingg/next.js canary	Change
index.html	3.62 kB	3.62 kB	✓
index.html gzip	946 B	946 B	✓
link.html	3.66 kB	3.66 kB	✓
link.html gzip	954 B	954 B	✓
withRouter.html	3.67 kB	3.67 kB	✓
withRouter.html gzip	941 B	941 B	✓
Overall change	10.9 kB	10.9 kB	✓

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	Zmingg/next.js canary	Change
buildDuration	15.4s	14.9s	-467ms
nodeModulesSize	48.5 MB	48.5 MB	⚠️ +224 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	Zmingg/next.js canary	Change
main-HASH.js	18.9 kB	18.9 kB	✓
main-HASH.js gzip	6.79 kB	6.79 kB	✓
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..9dda6167a.js	21.9 kB	21.9 kB	✓
4952ddcd88e7..167a.js gzip	7.81 kB	7.81 kB	✓
de003c3a9d30..3a0560775.js	43.2 kB	43.2 kB	✓
de003c3a9d30..0775.js gzip	15.5 kB	15.5 kB	✓
framework.5b..dbaff70d3.js	125 kB	125 kB	✓
framework.5b..70d3.js gzip	39.4 kB	39.4 kB	✓
Overall change	211 kB	211 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	Zmingg/next.js canary	Change
main-HASH.module.js	17.2 kB	17.2 kB	✓
main-HASH.module.js gzip	6.52 kB	6.52 kB	✓
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..72.module.js	45.6 kB	45.6 kB	✓
de003c3a9d30..dule.js gzip	16.5 kB	16.5 kB	✓
framework.5b..d3.module.js	125 kB	125 kB	✓
framework.5b..dule.js gzip	39.4 kB	39.4 kB	✓
Overall change	190 kB	190 kB	✓

Client Pages

	zeit/next.js canary	Zmingg/next.js canary	Change
_app.js	1.81 kB	1.81 kB	✓
_app.js gzip	873 B	873 B	✓
_error.js	12 kB	12 kB	✓
_error.js gzip	4.73 kB	4.73 kB	✓
hooks.js	12.7 kB	12.7 kB	✓
hooks.js gzip	4.79 kB	4.79 kB	✓
index.js	318 B	318 B	✓
index.js gzip	222 B	222 B	✓
link.js	8.14 kB	8.14 kB	✓
link.js gzip	3.5 kB	3.5 kB	✓
routerDirect.js	408 B	408 B	✓
routerDirect.js gzip	281 B	281 B	✓
withRouter.js	419 B	419 B	✓
withRouter.js gzip	280 B	280 B	✓
Overall change	35.8 kB	35.8 kB	✓

Client Pages Modern

	zeit/next.js canary	Zmingg/next.js canary	Change
_app.module.js	1.7 kB	1.7 kB	✓
_app.module.js gzip	832 B	832 B	✓
_error.module.js	23.3 kB	23.3 kB	✓
_error.module.js gzip	8.59 kB	8.59 kB	✓
hooks.module.js	1.52 kB	1.52 kB	✓
hooks.module.js gzip	793 B	793 B	✓
index.module.js	294 B	294 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js	8.53 kB	8.53 kB	✓
link.module.js gzip	3.68 kB	3.68 kB	✓
routerDirect.module.js	394 B	394 B	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.module.js	404 B	404 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	36.1 kB	36.1 kB	✓

Client Build Manifests

	zeit/next.js canary	Zmingg/next.js canary	Change
_buildManifest.js	81 B	81 B	✓
_buildManifest.js gzip	61 B	61 B	✓
_buildManifest.module.js	81 B	81 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	162 B	162 B	✓

Serverless bundles

	zeit/next.js canary	Zmingg/next.js canary	Change
_error.js	254 kB	254 kB	✓
_error.js gzip	68 kB	68 kB	✓
hooks.html	3.75 kB	3.75 kB	✓
hooks.html gzip	979 B	979 B	✓
index.js	254 kB	254 kB	✓
index.js gzip	68.3 kB	68.3 kB	✓
link.js	262 kB	262 kB	✓
link.js gzip	70.4 kB	70.4 kB	✓
routerDirect.js	255 kB	255 kB	✓
routerDirect.js gzip	68.4 kB	68.4 kB	✓
withRouter.js	255 kB	255 kB	✓
withRouter.js gzip	68.5 kB	68.5 kB	✓
Overall change	1.28 MB	1.28 MB	✓

Commit: 7b27ef8

ijjk · 2019-10-15T01:42:02Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	Zmingg/next.js canary	Change
buildDuration	16.1s	16.1s	-5ms
nodeModulesSize	48.5 MB	48.5 MB	⚠️ +224 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	Zmingg/next.js canary	Change
main-HASH.js	18.9 kB	18.9 kB	✓
main-HASH.js gzip	6.79 kB	6.79 kB	✓
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..9dda6167a.js	21.9 kB	21.9 kB	✓
4952ddcd88e7..167a.js gzip	7.81 kB	7.81 kB	✓
de003c3a9d30..3a0560775.js	43.2 kB	43.2 kB	✓
de003c3a9d30..0775.js gzip	15.5 kB	15.5 kB	✓
framework.5b..dbaff70d3.js	125 kB	125 kB	✓
framework.5b..70d3.js gzip	39.4 kB	39.4 kB	✓
Overall change	211 kB	211 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	Zmingg/next.js canary	Change
main-HASH.module.js	17.2 kB	17.2 kB	✓
main-HASH.module.js gzip	6.52 kB	6.52 kB	✓
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..72.module.js	45.6 kB	45.6 kB	✓
de003c3a9d30..dule.js gzip	16.5 kB	16.5 kB	✓
framework.5b..d3.module.js	125 kB	125 kB	✓
framework.5b..dule.js gzip	39.4 kB	39.4 kB	✓
Overall change	190 kB	190 kB	✓

Client Pages

	zeit/next.js canary	Zmingg/next.js canary	Change
_app.js	1.81 kB	1.81 kB	✓
_app.js gzip	873 B	873 B	✓
_error.js	12 kB	12 kB	✓
_error.js gzip	4.73 kB	4.73 kB	✓
hooks.js	12.7 kB	12.7 kB	✓
hooks.js gzip	4.79 kB	4.79 kB	✓
index.js	318 B	318 B	✓
index.js gzip	222 B	222 B	✓
link.js	8.14 kB	8.14 kB	✓
link.js gzip	3.5 kB	3.5 kB	✓
routerDirect.js	408 B	408 B	✓
routerDirect.js gzip	281 B	281 B	✓
withRouter.js	419 B	419 B	✓
withRouter.js gzip	280 B	280 B	✓
Overall change	35.8 kB	35.8 kB	✓

Client Pages Modern

	zeit/next.js canary	Zmingg/next.js canary	Change
_app.module.js	1.7 kB	1.7 kB	✓
_app.module.js gzip	832 B	832 B	✓
_error.module.js	23.3 kB	23.3 kB	✓
_error.module.js gzip	8.59 kB	8.59 kB	✓
hooks.module.js	1.52 kB	1.52 kB	✓
hooks.module.js gzip	793 B	793 B	✓
index.module.js	294 B	294 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js	8.53 kB	8.53 kB	✓
link.module.js gzip	3.68 kB	3.68 kB	✓
routerDirect.module.js	394 B	394 B	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.module.js	404 B	404 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	36.1 kB	36.1 kB	✓

Client Build Manifests

	zeit/next.js canary	Zmingg/next.js canary	Change
_buildManifest.js	81 B	81 B	✓
_buildManifest.js gzip	61 B	61 B	✓
_buildManifest.module.js	81 B	81 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	162 B	162 B	✓

Rendered Page Sizes

	zeit/next.js canary	Zmingg/next.js canary	Change
index.html	3.62 kB	3.62 kB	✓
index.html gzip	946 B	946 B	✓
link.html	3.66 kB	3.66 kB	✓
link.html gzip	954 B	954 B	✓
withRouter.html	3.67 kB	3.67 kB	✓
withRouter.html gzip	941 B	941 B	✓
Overall change	10.9 kB	10.9 kB	✓

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	Zmingg/next.js canary	Change
buildDuration	16.5s	16.3s	-162ms
nodeModulesSize	48.5 MB	48.5 MB	⚠️ +224 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	Zmingg/next.js canary	Change
main-HASH.js	18.9 kB	18.9 kB	✓
main-HASH.js gzip	6.79 kB	6.79 kB	✓
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..9dda6167a.js	21.9 kB	21.9 kB	✓
4952ddcd88e7..167a.js gzip	7.81 kB	7.81 kB	✓
de003c3a9d30..3a0560775.js	43.2 kB	43.2 kB	✓
de003c3a9d30..0775.js gzip	15.5 kB	15.5 kB	✓
framework.5b..dbaff70d3.js	125 kB	125 kB	✓
framework.5b..70d3.js gzip	39.4 kB	39.4 kB	✓
Overall change	211 kB	211 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	Zmingg/next.js canary	Change
main-HASH.module.js	17.2 kB	17.2 kB	✓
main-HASH.module.js gzip	6.52 kB	6.52 kB	✓
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..72.module.js	45.6 kB	45.6 kB	✓
de003c3a9d30..dule.js gzip	16.5 kB	16.5 kB	✓
framework.5b..d3.module.js	125 kB	125 kB	✓
framework.5b..dule.js gzip	39.4 kB	39.4 kB	✓
Overall change	190 kB	190 kB	✓

Client Pages

	zeit/next.js canary	Zmingg/next.js canary	Change
_app.js	1.81 kB	1.81 kB	✓
_app.js gzip	873 B	873 B	✓
_error.js	12 kB	12 kB	✓
_error.js gzip	4.73 kB	4.73 kB	✓
hooks.js	12.7 kB	12.7 kB	✓
hooks.js gzip	4.79 kB	4.79 kB	✓
index.js	318 B	318 B	✓
index.js gzip	222 B	222 B	✓
link.js	8.14 kB	8.14 kB	✓
link.js gzip	3.5 kB	3.5 kB	✓
routerDirect.js	408 B	408 B	✓
routerDirect.js gzip	281 B	281 B	✓
withRouter.js	419 B	419 B	✓
withRouter.js gzip	280 B	280 B	✓
Overall change	35.8 kB	35.8 kB	✓

Client Pages Modern

	zeit/next.js canary	Zmingg/next.js canary	Change
_app.module.js	1.7 kB	1.7 kB	✓
_app.module.js gzip	832 B	832 B	✓
_error.module.js	23.3 kB	23.3 kB	✓
_error.module.js gzip	8.59 kB	8.59 kB	✓
hooks.module.js	1.52 kB	1.52 kB	✓
hooks.module.js gzip	793 B	793 B	✓
index.module.js	294 B	294 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js	8.53 kB	8.53 kB	✓
link.module.js gzip	3.68 kB	3.68 kB	✓
routerDirect.module.js	394 B	394 B	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.module.js	404 B	404 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	36.1 kB	36.1 kB	✓

Client Build Manifests

	zeit/next.js canary	Zmingg/next.js canary	Change
_buildManifest.js	81 B	81 B	✓
_buildManifest.js gzip	61 B	61 B	✓
_buildManifest.module.js	81 B	81 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	162 B	162 B	✓

Serverless bundles

	zeit/next.js canary	Zmingg/next.js canary	Change
_error.js	254 kB	254 kB	✓
_error.js gzip	68 kB	68 kB	✓
hooks.html	3.75 kB	3.75 kB	✓
hooks.html gzip	979 B	979 B	✓
index.js	254 kB	254 kB	✓
index.js gzip	68.4 kB	68.4 kB	✓
link.js	262 kB	262 kB	✓
link.js gzip	70.4 kB	70.4 kB	✓
routerDirect.js	255 kB	255 kB	✓
routerDirect.js gzip	68.4 kB	68.4 kB	✓
withRouter.js	255 kB	255 kB	✓
withRouter.js gzip	68.5 kB	68.5 kB	✓
Overall change	1.28 MB	1.28 MB	✓

Commit: b52fa5e

timneutkens · 2019-10-15T08:09:28Z

Can you make sure the tests pass 🙏

Timer · 2019-10-18T05:27:47Z

We'll likely need to bump all Babel dependencies.

update typescript preset

9126369

Zmingg requested review from ijjk, lfades, Timer and timneutkens as code owners September 25, 2019 07:45

Zmingg closed this Sep 25, 2019

Zmingg reopened this Sep 25, 2019

Zmingg changed the title ~~Update typescript preset to 7.6.0~~ Fix passing of "allowNamespaces" in @babel/preset-typescrip Sep 25, 2019

Zmingg added 3 commits September 26, 2019 11:03

Merge branch 'canary' into canary

db84f1d

Merge branch 'canary' into canary

ef3e395

Merge branch 'canary' into canary

5573b62

Zmingg mentioned this pull request Sep 29, 2019

Namespaces not supported in next/babel for preset-typescript: 7.3.3 #8900

Closed

Zmingg and others added 2 commits October 4, 2019 17:26

Merge branch 'canary' into canary

0c0dfcc

Merge branch 'canary' into canary

7b27ef8

Merge branch 'canary' into canary

b52fa5e

Timer added this to the 9.1.x milestone Oct 18, 2019

Timer added the priority: medium label Oct 18, 2019

timneutkens mentioned this pull request Oct 26, 2019

Update Babel dependencies #9203

Merged

timneutkens closed this in #9203 Oct 26, 2019

Timer modified the milestones: 9.1.x, 9.1.2 Oct 27, 2019

vercel locked as resolved and limited conversation to collaborators Jan 31, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix passing of "allowNamespaces" in @babel/preset-typescrip #8849

Fix passing of "allowNamespaces" in @babel/preset-typescrip #8849

Zmingg commented Sep 25, 2019

Zmingg commented Sep 25, 2019 •

edited

ijjk commented Oct 14, 2019

ijjk commented Oct 15, 2019

timneutkens commented Oct 15, 2019

Timer commented Oct 18, 2019

Fix passing of "allowNamespaces" in @babel/preset-typescrip #8849

Fix passing of "allowNamespaces" in @babel/preset-typescrip #8849

Conversation

Zmingg commented Sep 25, 2019

Zmingg commented Sep 25, 2019 • edited

ijjk commented Oct 14, 2019

Stats from current PR

ijjk commented Oct 15, 2019

Stats from current PR

timneutkens commented Oct 15, 2019

Timer commented Oct 18, 2019

Zmingg commented Sep 25, 2019 •

edited