Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update _app documentation to reflect no longer needing next/app #9268

Merged
merged 4 commits into from
Oct 31, 2019
Merged

Update _app documentation to reflect no longer needing next/app #9268

merged 4 commits into from
Oct 31, 2019

Conversation

timneutkens
Copy link
Member

Updates the _app docs to reflect it now being able to provide a function component.

This also brings back prettier/standard etc on commit that was removed here: https://github.com/zeit/next.js/pull/9245/files#diff-b9cfc7f2cdf78a7f4b91a753d10865a2L31-L49

Fixes #7515

@ijjk
Copy link
Member

ijjk commented Oct 31, 2019

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall decrease ✓
zeit/next.js canary timneutkens/next.js add/update-app-docs Change
buildDuration 14.7s 14.9s ⚠️ +233ms
nodeModulesSize 48.5 MB 48.5 MB -219 B
Client Bundles (main, webpack, commons)
zeit/next.js canary timneutkens/next.js add/update-app-docs Change
main-HASH.js 16.6 kB 16.6 kB ✓
main-HASH.js gzip 5.86 kB 5.86 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
16b1a7225520..63e75d588.js 19.7 kB 19.7 kB ✓
16b1a7225520..d588.js gzip 7.23 kB 7.23 kB ✓
4952ddcd88e7..bfe360fe6.js 10.5 kB 10.5 kB ✓
4952ddcd88e7..0fe6.js gzip 4.06 kB 4.06 kB ✓
commons.HASH.js 11.3 kB 11.3 kB ✓
commons.HASH.js gzip 4.23 kB 4.23 kB ✓
de003c3a9d30..9e9c1d310.js 28.6 kB 28.6 kB ✓
de003c3a9d30..d310.js gzip 10.8 kB 10.8 kB ✓
framework.1b..cdcfe1283.js 125 kB 125 kB ✓
framework.1b..1283.js gzip 39.4 kB 39.4 kB ✓
Overall change 214 kB 214 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary timneutkens/next.js add/update-app-docs Change
main-HASH.module.js 14.1 kB 14.1 kB ✓
main-HASH.module.js gzip 5.28 kB 5.28 kB ✓
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
16b1a7225520..51.module.js 15.8 kB 15.8 kB ✓
16b1a7225520..dule.js gzip 6.07 kB 6.07 kB ✓
4952ddcd88e7..4a.module.js 12.8 kB 12.8 kB ✓
4952ddcd88e7..dule.js gzip 4.75 kB 4.75 kB ✓
de003c3a9d30..c0.module.js 22.1 kB 22.1 kB ✓
de003c3a9d30..dule.js gzip 8.68 kB 8.68 kB ✓
framework.5b..d3.module.js 125 kB 125 kB ✓
framework.5b..dule.js gzip 39.4 kB 39.4 kB ✓
Overall change 192 kB 192 kB ✓
Client Pages
zeit/next.js canary timneutkens/next.js add/update-app-docs Change
_app.js 1.63 kB 1.63 kB ✓
_app.js gzip 788 B 788 B ✓
_error.js 12.3 kB 12.3 kB ✓
_error.js gzip 4.79 kB 4.79 kB ✓
hooks.js 1.92 kB 1.92 kB ✓
hooks.js gzip 941 B 941 B ✓
index.js 318 B 318 B ✓
index.js gzip 222 B 222 B ✓
link.js 5.81 kB 5.81 kB ✓
link.js gzip 2.56 kB 2.56 kB ✓
routerDirect.js 413 B 413 B ✓
routerDirect.js gzip 285 B 285 B ✓
withRouter.js 423 B 423 B ✓
withRouter.js gzip 284 B 284 B ✓
Overall change 22.8 kB 22.8 kB ✓
Client Pages Modern
zeit/next.js canary timneutkens/next.js add/update-app-docs Change
_app.module.js 1.54 kB 1.54 kB ✓
_app.module.js gzip 759 B 759 B ✓
_error.module.js 10.5 kB 10.5 kB ✓
_error.module.js gzip 4.26 kB 4.26 kB ✓
hooks.module.js 1.52 kB 1.52 kB ✓
hooks.module.js gzip 792 B 792 B ✓
index.module.js 292 B 292 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js 5.49 kB 5.49 kB ✓
link.module.js gzip 2.47 kB 2.47 kB ✓
routerDirect.module.js 399 B 399 B ✓
routerDirect..dule.js gzip 285 B 285 B ✓
withRouter.module.js 409 B 409 B ✓
withRouter.m..dule.js gzip 282 B 282 B ✓
Overall change 20.2 kB 20.2 kB ✓
Client Build Manifests
zeit/next.js canary timneutkens/next.js add/update-app-docs Change
_buildManifest.js 244 B 244 B ✓
_buildManifest.js gzip 199 B 199 B ✓
_buildManifest.module.js 251 B 251 B ✓
_buildManife..dule.js gzip 210 B 210 B ✓
Overall change 495 B 495 B ✓
Rendered Page Sizes
zeit/next.js canary timneutkens/next.js add/update-app-docs Change
index.html 3.94 kB 3.94 kB ✓
index.html gzip 1 kB 1 kB ✓
link.html 4.47 kB 4.47 kB ✓
link.html gzip 1.08 kB 1.08 kB ✓
withRouter.html 4.47 kB 4.47 kB ✓
withRouter.html gzip 1.07 kB 1.07 kB ✓
Overall change 12.9 kB 12.9 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
zeit/next.js canary timneutkens/next.js add/update-app-docs Change
buildDuration 15.6s 15.1s -535ms
nodeModulesSize 48.5 MB 48.5 MB -219 B
Client Bundles (main, webpack, commons)
zeit/next.js canary timneutkens/next.js add/update-app-docs Change
main-HASH.js 16.6 kB 16.6 kB ✓
main-HASH.js gzip 5.86 kB 5.86 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
16b1a7225520..63e75d588.js 19.7 kB 19.7 kB ✓
16b1a7225520..d588.js gzip 7.23 kB 7.23 kB ✓
4952ddcd88e7..bfe360fe6.js 10.5 kB 10.5 kB ✓
4952ddcd88e7..0fe6.js gzip 4.06 kB 4.06 kB ✓
commons.HASH.js 11.3 kB 11.3 kB ✓
commons.HASH.js gzip 4.23 kB 4.23 kB ✓
de003c3a9d30..9e9c1d310.js 28.6 kB 28.6 kB ✓
de003c3a9d30..d310.js gzip 10.8 kB 10.8 kB ✓
framework.1b..cdcfe1283.js 125 kB 125 kB ✓
framework.1b..1283.js gzip 39.4 kB 39.4 kB ✓
Overall change 214 kB 214 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary timneutkens/next.js add/update-app-docs Change
main-HASH.module.js 14.1 kB 14.1 kB ✓
main-HASH.module.js gzip 5.28 kB 5.28 kB ✓
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
16b1a7225520..51.module.js 15.8 kB 15.8 kB ✓
16b1a7225520..dule.js gzip 6.07 kB 6.07 kB ✓
4952ddcd88e7..4a.module.js 12.8 kB 12.8 kB ✓
4952ddcd88e7..dule.js gzip 4.75 kB 4.75 kB ✓
de003c3a9d30..c0.module.js 22.1 kB 22.1 kB ✓
de003c3a9d30..dule.js gzip 8.68 kB 8.68 kB ✓
framework.5b..d3.module.js 125 kB 125 kB ✓
framework.5b..dule.js gzip 39.4 kB 39.4 kB ✓
Overall change 192 kB 192 kB ✓
Client Pages
zeit/next.js canary timneutkens/next.js add/update-app-docs Change
_app.js 1.63 kB 1.63 kB ✓
_app.js gzip 788 B 788 B ✓
_error.js 12.3 kB 12.3 kB ✓
_error.js gzip 4.79 kB 4.79 kB ✓
hooks.js 1.92 kB 1.92 kB ✓
hooks.js gzip 941 B 941 B ✓
index.js 318 B 318 B ✓
index.js gzip 222 B 222 B ✓
link.js 5.81 kB 5.81 kB ✓
link.js gzip 2.56 kB 2.56 kB ✓
routerDirect.js 413 B 413 B ✓
routerDirect.js gzip 285 B 285 B ✓
withRouter.js 423 B 423 B ✓
withRouter.js gzip 284 B 284 B ✓
Overall change 22.8 kB 22.8 kB ✓
Client Pages Modern
zeit/next.js canary timneutkens/next.js add/update-app-docs Change
_app.module.js 1.54 kB 1.54 kB ✓
_app.module.js gzip 759 B 759 B ✓
_error.module.js 10.5 kB 10.5 kB ✓
_error.module.js gzip 4.26 kB 4.26 kB ✓
hooks.module.js 1.52 kB 1.52 kB ✓
hooks.module.js gzip 792 B 792 B ✓
index.module.js 292 B 292 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js 5.49 kB 5.49 kB ✓
link.module.js gzip 2.47 kB 2.47 kB ✓
routerDirect.module.js 399 B 399 B ✓
routerDirect..dule.js gzip 285 B 285 B ✓
withRouter.module.js 409 B 409 B ✓
withRouter.m..dule.js gzip 282 B 282 B ✓
Overall change 20.2 kB 20.2 kB ✓
Client Build Manifests
zeit/next.js canary timneutkens/next.js add/update-app-docs Change
_buildManifest.js 244 B 244 B ✓
_buildManifest.js gzip 199 B 199 B ✓
_buildManifest.module.js 251 B 251 B ✓
_buildManife..dule.js gzip 210 B 210 B ✓
Overall change 495 B 495 B ✓
Serverless bundles
zeit/next.js canary timneutkens/next.js add/update-app-docs Change
_error.js 241 kB 241 kB ✓
_error.js gzip 64.4 kB 64.4 kB ✓
hooks.html 4.08 kB 4.08 kB ✓
hooks.html gzip 1.03 kB 1.03 kB ✓
index.js 241 kB 241 kB ✓
index.js gzip 64.5 kB 64.5 kB ✓
link.js 274 kB 274 kB ✓
link.js gzip 73.5 kB 73.5 kB ✓
routerDirect.js 267 kB 267 kB ✓
routerDirect.js gzip 71.5 kB 71.5 kB ✓
withRouter.js 267 kB 267 kB ✓
withRouter.js gzip 71.6 kB 71.6 kB ✓
Overall change 1.29 MB 1.29 MB ✓

Commit: 5b0194d

@ijjk
Copy link
Member

ijjk commented Oct 31, 2019

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall decrease ✓
zeit/next.js canary timneutkens/next.js add/update-app-docs Change
buildDuration 14.9s 14.9s ⚠️ +4ms
nodeModulesSize 48.5 MB 48.5 MB -219 B
Client Bundles (main, webpack, commons)
zeit/next.js canary timneutkens/next.js add/update-app-docs Change
main-HASH.js 16.6 kB 16.6 kB ✓
main-HASH.js gzip 5.86 kB 5.86 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
16b1a7225520..63e75d588.js 19.7 kB 19.7 kB ✓
16b1a7225520..d588.js gzip 7.23 kB 7.23 kB ✓
4952ddcd88e7..bfe360fe6.js 10.5 kB 10.5 kB ✓
4952ddcd88e7..0fe6.js gzip 4.06 kB 4.06 kB ✓
commons.HASH.js 11.3 kB 11.3 kB ✓
commons.HASH.js gzip 4.23 kB 4.23 kB ✓
de003c3a9d30..9e9c1d310.js 28.6 kB 28.6 kB ✓
de003c3a9d30..d310.js gzip 10.8 kB 10.8 kB ✓
framework.1b..cdcfe1283.js 125 kB 125 kB ✓
framework.1b..1283.js gzip 39.4 kB 39.4 kB ✓
Overall change 214 kB 214 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary timneutkens/next.js add/update-app-docs Change
main-HASH.module.js 14.1 kB 14.1 kB ✓
main-HASH.module.js gzip 5.28 kB 5.28 kB ✓
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
16b1a7225520..51.module.js 15.8 kB 15.8 kB ✓
16b1a7225520..dule.js gzip 6.07 kB 6.07 kB ✓
4952ddcd88e7..4a.module.js 12.8 kB 12.8 kB ✓
4952ddcd88e7..dule.js gzip 4.75 kB 4.75 kB ✓
de003c3a9d30..c0.module.js 22.1 kB 22.1 kB ✓
de003c3a9d30..dule.js gzip 8.68 kB 8.68 kB ✓
framework.5b..d3.module.js 125 kB 125 kB ✓
framework.5b..dule.js gzip 39.4 kB 39.4 kB ✓
Overall change 192 kB 192 kB ✓
Client Pages
zeit/next.js canary timneutkens/next.js add/update-app-docs Change
_app.js 1.63 kB 1.63 kB ✓
_app.js gzip 788 B 788 B ✓
_error.js 12.3 kB 12.3 kB ✓
_error.js gzip 4.79 kB 4.79 kB ✓
hooks.js 1.92 kB 1.92 kB ✓
hooks.js gzip 941 B 941 B ✓
index.js 318 B 318 B ✓
index.js gzip 222 B 222 B ✓
link.js 5.81 kB 5.81 kB ✓
link.js gzip 2.56 kB 2.56 kB ✓
routerDirect.js 413 B 413 B ✓
routerDirect.js gzip 285 B 285 B ✓
withRouter.js 423 B 423 B ✓
withRouter.js gzip 284 B 284 B ✓
Overall change 22.8 kB 22.8 kB ✓
Client Pages Modern
zeit/next.js canary timneutkens/next.js add/update-app-docs Change
_app.module.js 1.54 kB 1.54 kB ✓
_app.module.js gzip 759 B 759 B ✓
_error.module.js 10.5 kB 10.5 kB ✓
_error.module.js gzip 4.26 kB 4.26 kB ✓
hooks.module.js 1.52 kB 1.52 kB ✓
hooks.module.js gzip 792 B 792 B ✓
index.module.js 292 B 292 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js 5.49 kB 5.49 kB ✓
link.module.js gzip 2.47 kB 2.47 kB ✓
routerDirect.module.js 399 B 399 B ✓
routerDirect..dule.js gzip 285 B 285 B ✓
withRouter.module.js 409 B 409 B ✓
withRouter.m..dule.js gzip 282 B 282 B ✓
Overall change 20.2 kB 20.2 kB ✓
Client Build Manifests
zeit/next.js canary timneutkens/next.js add/update-app-docs Change
_buildManifest.js 244 B 244 B ✓
_buildManifest.js gzip 199 B 199 B ✓
_buildManifest.module.js 251 B 251 B ✓
_buildManife..dule.js gzip 210 B 210 B ✓
Overall change 495 B 495 B ✓
Rendered Page Sizes
zeit/next.js canary timneutkens/next.js add/update-app-docs Change
index.html 3.94 kB 3.94 kB ✓
index.html gzip 1 kB 1 kB ✓
link.html 4.47 kB 4.47 kB ✓
link.html gzip 1.08 kB 1.08 kB ✓
withRouter.html 4.47 kB 4.47 kB ✓
withRouter.html gzip 1.07 kB 1.07 kB ✓
Overall change 12.9 kB 12.9 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
zeit/next.js canary timneutkens/next.js add/update-app-docs Change
buildDuration 15.1s 15.2s ⚠️ +170ms
nodeModulesSize 48.5 MB 48.5 MB -219 B
Client Bundles (main, webpack, commons)
zeit/next.js canary timneutkens/next.js add/update-app-docs Change
main-HASH.js 16.6 kB 16.6 kB ✓
main-HASH.js gzip 5.86 kB 5.86 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
16b1a7225520..63e75d588.js 19.7 kB 19.7 kB ✓
16b1a7225520..d588.js gzip 7.23 kB 7.23 kB ✓
4952ddcd88e7..bfe360fe6.js 10.5 kB 10.5 kB ✓
4952ddcd88e7..0fe6.js gzip 4.06 kB 4.06 kB ✓
commons.HASH.js 11.3 kB 11.3 kB ✓
commons.HASH.js gzip 4.23 kB 4.23 kB ✓
de003c3a9d30..9e9c1d310.js 28.6 kB 28.6 kB ✓
de003c3a9d30..d310.js gzip 10.8 kB 10.8 kB ✓
framework.1b..cdcfe1283.js 125 kB 125 kB ✓
framework.1b..1283.js gzip 39.4 kB 39.4 kB ✓
Overall change 214 kB 214 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary timneutkens/next.js add/update-app-docs Change
main-HASH.module.js 14.1 kB 14.1 kB ✓
main-HASH.module.js gzip 5.28 kB 5.28 kB ✓
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
16b1a7225520..51.module.js 15.8 kB 15.8 kB ✓
16b1a7225520..dule.js gzip 6.07 kB 6.07 kB ✓
4952ddcd88e7..4a.module.js 12.8 kB 12.8 kB ✓
4952ddcd88e7..dule.js gzip 4.75 kB 4.75 kB ✓
de003c3a9d30..c0.module.js 22.1 kB 22.1 kB ✓
de003c3a9d30..dule.js gzip 8.68 kB 8.68 kB ✓
framework.5b..d3.module.js 125 kB 125 kB ✓
framework.5b..dule.js gzip 39.4 kB 39.4 kB ✓
Overall change 192 kB 192 kB ✓
Client Pages
zeit/next.js canary timneutkens/next.js add/update-app-docs Change
_app.js 1.63 kB 1.63 kB ✓
_app.js gzip 788 B 788 B ✓
_error.js 12.3 kB 12.3 kB ✓
_error.js gzip 4.79 kB 4.79 kB ✓
hooks.js 1.92 kB 1.92 kB ✓
hooks.js gzip 941 B 941 B ✓
index.js 318 B 318 B ✓
index.js gzip 222 B 222 B ✓
link.js 5.81 kB 5.81 kB ✓
link.js gzip 2.56 kB 2.56 kB ✓
routerDirect.js 413 B 413 B ✓
routerDirect.js gzip 285 B 285 B ✓
withRouter.js 423 B 423 B ✓
withRouter.js gzip 284 B 284 B ✓
Overall change 22.8 kB 22.8 kB ✓
Client Pages Modern
zeit/next.js canary timneutkens/next.js add/update-app-docs Change
_app.module.js 1.54 kB 1.54 kB ✓
_app.module.js gzip 759 B 759 B ✓
_error.module.js 10.5 kB 10.5 kB ✓
_error.module.js gzip 4.26 kB 4.26 kB ✓
hooks.module.js 1.52 kB 1.52 kB ✓
hooks.module.js gzip 792 B 792 B ✓
index.module.js 292 B 292 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js 5.49 kB 5.49 kB ✓
link.module.js gzip 2.47 kB 2.47 kB ✓
routerDirect.module.js 399 B 399 B ✓
routerDirect..dule.js gzip 285 B 285 B ✓
withRouter.module.js 409 B 409 B ✓
withRouter.m..dule.js gzip 282 B 282 B ✓
Overall change 20.2 kB 20.2 kB ✓
Client Build Manifests
zeit/next.js canary timneutkens/next.js add/update-app-docs Change
_buildManifest.js 244 B 244 B ✓
_buildManifest.js gzip 199 B 199 B ✓
_buildManifest.module.js 251 B 251 B ✓
_buildManife..dule.js gzip 210 B 210 B ✓
Overall change 495 B 495 B ✓
Serverless bundles
zeit/next.js canary timneutkens/next.js add/update-app-docs Change
_error.js 241 kB 241 kB ✓
_error.js gzip 64.4 kB 64.4 kB ✓
hooks.html 4.08 kB 4.08 kB ✓
hooks.html gzip 1.03 kB 1.03 kB ✓
index.js 241 kB 241 kB ✓
index.js gzip 64.5 kB 64.5 kB ✓
link.js 274 kB 274 kB ✓
link.js gzip 73.5 kB 73.5 kB ✓
routerDirect.js 267 kB 267 kB ✓
routerDirect.js gzip 71.5 kB 71.5 kB ✓
withRouter.js 267 kB 267 kB ✓
withRouter.js gzip 71.6 kB 71.6 kB ✓
Overall change 1.29 MB 1.29 MB ✓

Commit: 89eadf5

@Timer Timer added this to the 9.1.3 milestone Oct 31, 2019
@ijjk
Copy link
Member

ijjk commented Oct 31, 2019

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall decrease ✓
zeit/next.js canary timneutkens/next.js add/update-app-docs Change
buildDuration 14.2s 14.3s ⚠️ +154ms
nodeModulesSize 48.5 MB 48.5 MB -171 B
Client Bundles (main, webpack, commons)
zeit/next.js canary timneutkens/next.js add/update-app-docs Change
main-HASH.js 16.6 kB 16.6 kB ✓
main-HASH.js gzip 5.86 kB 5.86 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
16b1a7225520..63e75d588.js 19.7 kB 19.7 kB ✓
16b1a7225520..d588.js gzip 7.23 kB 7.23 kB ✓
4952ddcd88e7..bfe360fe6.js 10.5 kB 10.5 kB ✓
4952ddcd88e7..0fe6.js gzip 4.06 kB 4.06 kB ✓
commons.HASH.js 11.3 kB 11.3 kB ✓
commons.HASH.js gzip 4.23 kB 4.23 kB ✓
de003c3a9d30..9e9c1d310.js 28.6 kB 28.6 kB ✓
de003c3a9d30..d310.js gzip 10.8 kB 10.8 kB ✓
framework.1b..cdcfe1283.js 125 kB 125 kB ✓
framework.1b..1283.js gzip 39.4 kB 39.4 kB ✓
Overall change 214 kB 214 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary timneutkens/next.js add/update-app-docs Change
main-HASH.module.js 14.1 kB 14.1 kB ✓
main-HASH.module.js gzip 5.28 kB 5.28 kB ✓
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
16b1a7225520..51.module.js 15.8 kB 15.8 kB ✓
16b1a7225520..dule.js gzip 6.07 kB 6.07 kB ✓
4952ddcd88e7..4a.module.js 12.8 kB 12.8 kB ✓
4952ddcd88e7..dule.js gzip 4.75 kB 4.75 kB ✓
de003c3a9d30..c0.module.js 22.1 kB 22.1 kB ✓
de003c3a9d30..dule.js gzip 8.68 kB 8.68 kB ✓
framework.5b..d3.module.js 125 kB 125 kB ✓
framework.5b..dule.js gzip 39.4 kB 39.4 kB ✓
Overall change 192 kB 192 kB ✓
Client Pages
zeit/next.js canary timneutkens/next.js add/update-app-docs Change
_app.js 1.63 kB 1.63 kB ✓
_app.js gzip 788 B 788 B ✓
_error.js 12.3 kB 12.3 kB ✓
_error.js gzip 4.79 kB 4.79 kB ✓
hooks.js 1.92 kB 1.92 kB ✓
hooks.js gzip 941 B 941 B ✓
index.js 318 B 318 B ✓
index.js gzip 222 B 222 B ✓
link.js 5.81 kB 5.81 kB ✓
link.js gzip 2.56 kB 2.56 kB ✓
routerDirect.js 413 B 413 B ✓
routerDirect.js gzip 285 B 285 B ✓
withRouter.js 423 B 423 B ✓
withRouter.js gzip 284 B 284 B ✓
Overall change 22.8 kB 22.8 kB ✓
Client Pages Modern
zeit/next.js canary timneutkens/next.js add/update-app-docs Change
_app.module.js 1.54 kB 1.54 kB ✓
_app.module.js gzip 759 B 759 B ✓
_error.module.js 10.5 kB 10.5 kB ✓
_error.module.js gzip 4.26 kB 4.26 kB ✓
hooks.module.js 1.52 kB 1.52 kB ✓
hooks.module.js gzip 792 B 792 B ✓
index.module.js 292 B 292 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js 5.49 kB 5.49 kB ✓
link.module.js gzip 2.47 kB 2.47 kB ✓
routerDirect.module.js 399 B 399 B ✓
routerDirect..dule.js gzip 285 B 285 B ✓
withRouter.module.js 409 B 409 B ✓
withRouter.m..dule.js gzip 282 B 282 B ✓
Overall change 20.2 kB 20.2 kB ✓
Client Build Manifests
zeit/next.js canary timneutkens/next.js add/update-app-docs Change
_buildManifest.js 244 B 244 B ✓
_buildManifest.js gzip 199 B 199 B ✓
_buildManifest.module.js 251 B 251 B ✓
_buildManife..dule.js gzip 210 B 210 B ✓
Overall change 495 B 495 B ✓
Rendered Page Sizes
zeit/next.js canary timneutkens/next.js add/update-app-docs Change
index.html 3.94 kB 3.94 kB ✓
index.html gzip 1 kB 1 kB ✓
link.html 4.47 kB 4.47 kB ✓
link.html gzip 1.08 kB 1.08 kB ✓
withRouter.html 4.47 kB 4.47 kB ✓
withRouter.html gzip 1.07 kB 1.07 kB ✓
Overall change 12.9 kB 12.9 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
zeit/next.js canary timneutkens/next.js add/update-app-docs Change
buildDuration 15s 14.5s -472ms
nodeModulesSize 48.5 MB 48.5 MB -171 B
Client Bundles (main, webpack, commons)
zeit/next.js canary timneutkens/next.js add/update-app-docs Change
main-HASH.js 16.6 kB 16.6 kB ✓
main-HASH.js gzip 5.86 kB 5.86 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
16b1a7225520..63e75d588.js 19.7 kB 19.7 kB ✓
16b1a7225520..d588.js gzip 7.23 kB 7.23 kB ✓
4952ddcd88e7..bfe360fe6.js 10.5 kB 10.5 kB ✓
4952ddcd88e7..0fe6.js gzip 4.06 kB 4.06 kB ✓
commons.HASH.js 11.3 kB 11.3 kB ✓
commons.HASH.js gzip 4.23 kB 4.23 kB ✓
de003c3a9d30..9e9c1d310.js 28.6 kB 28.6 kB ✓
de003c3a9d30..d310.js gzip 10.8 kB 10.8 kB ✓
framework.1b..cdcfe1283.js 125 kB 125 kB ✓
framework.1b..1283.js gzip 39.4 kB 39.4 kB ✓
Overall change 214 kB 214 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary timneutkens/next.js add/update-app-docs Change
main-HASH.module.js 14.1 kB 14.1 kB ✓
main-HASH.module.js gzip 5.28 kB 5.28 kB ✓
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
16b1a7225520..51.module.js 15.8 kB 15.8 kB ✓
16b1a7225520..dule.js gzip 6.07 kB 6.07 kB ✓
4952ddcd88e7..4a.module.js 12.8 kB 12.8 kB ✓
4952ddcd88e7..dule.js gzip 4.75 kB 4.75 kB ✓
de003c3a9d30..c0.module.js 22.1 kB 22.1 kB ✓
de003c3a9d30..dule.js gzip 8.68 kB 8.68 kB ✓
framework.5b..d3.module.js 125 kB 125 kB ✓
framework.5b..dule.js gzip 39.4 kB 39.4 kB ✓
Overall change 192 kB 192 kB ✓
Client Pages
zeit/next.js canary timneutkens/next.js add/update-app-docs Change
_app.js 1.63 kB 1.63 kB ✓
_app.js gzip 788 B 788 B ✓
_error.js 12.3 kB 12.3 kB ✓
_error.js gzip 4.79 kB 4.79 kB ✓
hooks.js 1.92 kB 1.92 kB ✓
hooks.js gzip 941 B 941 B ✓
index.js 318 B 318 B ✓
index.js gzip 222 B 222 B ✓
link.js 5.81 kB 5.81 kB ✓
link.js gzip 2.56 kB 2.56 kB ✓
routerDirect.js 413 B 413 B ✓
routerDirect.js gzip 285 B 285 B ✓
withRouter.js 423 B 423 B ✓
withRouter.js gzip 284 B 284 B ✓
Overall change 22.8 kB 22.8 kB ✓
Client Pages Modern
zeit/next.js canary timneutkens/next.js add/update-app-docs Change
_app.module.js 1.54 kB 1.54 kB ✓
_app.module.js gzip 759 B 759 B ✓
_error.module.js 10.5 kB 10.5 kB ✓
_error.module.js gzip 4.26 kB 4.26 kB ✓
hooks.module.js 1.52 kB 1.52 kB ✓
hooks.module.js gzip 792 B 792 B ✓
index.module.js 292 B 292 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js 5.49 kB 5.49 kB ✓
link.module.js gzip 2.47 kB 2.47 kB ✓
routerDirect.module.js 399 B 399 B ✓
routerDirect..dule.js gzip 285 B 285 B ✓
withRouter.module.js 409 B 409 B ✓
withRouter.m..dule.js gzip 282 B 282 B ✓
Overall change 20.2 kB 20.2 kB ✓
Client Build Manifests
zeit/next.js canary timneutkens/next.js add/update-app-docs Change
_buildManifest.js 244 B 244 B ✓
_buildManifest.js gzip 199 B 199 B ✓
_buildManifest.module.js 251 B 251 B ✓
_buildManife..dule.js gzip 210 B 210 B ✓
Overall change 495 B 495 B ✓
Serverless bundles
zeit/next.js canary timneutkens/next.js add/update-app-docs Change
_error.js 241 kB 241 kB ✓
_error.js gzip 64.4 kB 64.4 kB ✓
hooks.html 4.08 kB 4.08 kB ✓
hooks.html gzip 1.03 kB 1.03 kB ✓
index.js 241 kB 241 kB ✓
index.js gzip 64.5 kB 64.5 kB ✓
link.js 274 kB 274 kB ✓
link.js gzip 73.5 kB 73.5 kB ✓
routerDirect.js 267 kB 267 kB ✓
routerDirect.js gzip 71.5 kB 71.5 kB ✓
withRouter.js 267 kB 267 kB ✓
withRouter.js gzip 71.6 kB 71.6 kB ✓
Overall change 1.29 MB 1.29 MB ✓

Commit: 9677abc

@Timer Timer merged commit 37ee8fc into vercel:canary Oct 31, 2019
@timneutkens timneutkens deleted the add/update-app-docs branch October 31, 2019 15:01
@jaydenseric jaydenseric mentioned this pull request Nov 2, 2019
Closed
This was referenced Nov 19, 2019
Merged
Open
@amalv amalv mentioned this pull request Dec 18, 2019
Closed
@vercel vercel locked as resolved and limited conversation to collaborators Jan 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Timer Timer Timer approved these changes

@ijjk ijjk ijjk approved these changes

@lfades lfades Awaiting requested review from lfades

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
9.1.3
Development

Successfully merging this pull request may close these issues.

next/app as functional component
3 participants
@timneutkens @ijjk @Timer