feat: support import assertions #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onsclom
requested review from
trek,
EndangeredMassa,
TooTallNate,
jeffsee55 and
erikareads
TooTallNate
approved these changes
May 9, 2024
trek
approved these changes
May 9, 2024
styfle
reviewed
May 9, 2024
There was a problem hiding this comment.
@onsclom I believe assert was renamed to with.
Can you also add a test for with as well?
|
🎉 This PR is included in version 0.27.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
styfle
added a commit
to vercel/next.js
that referenced
this pull request
May 16, 2024
- vercel/nft#415 ([e001d05](vercel/nft@e001d05)) - vercel/nft#417 ([ddc5cba](vercel/nft@ddc5cba)) - vercel/nft#419 ([db6c65a](vercel/nft@db6c65a))
panteliselef
pushed a commit
to panteliselef/next.js
that referenced
this pull request
May 20, 2024
- vercel/nft#415 ([e001d05](vercel/nft@e001d05)) - vercel/nft#417 ([ddc5cba](vercel/nft@ddc5cba)) - vercel/nft#419 ([db6c65a](vercel/nft@db6c65a))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
acorn-import-attributesdid not support import assertions before, but now it does!This is important because
acornis failing to parserunner.jsin this issue due to an import assertion.