Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Khmer language (Cambodia) #177

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Conversation

seanghay
Copy link

@seanghay seanghay commented Oct 12, 2022

Support Khmer language

@vercel
Copy link

vercel bot commented Oct 12, 2022

@seanghay is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Oct 12, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
satori-playground ✅ Ready (Inspect) Visit Preview Oct 13, 2022 at 4:34PM (UTC)

@shuding
Copy link
Member

shuding commented Oct 12, 2022

Hi! Could you add a test to test/language.test.tsx?

@seanghay
Copy link
Author

Hi @shuding! I've added the test now.

@shuding
Copy link
Member

shuding commented Oct 12, 2022

Thanks! It seems that the characters are not rendering on the playground, I'll invest why.

@seanghay
Copy link
Author

seanghay commented Oct 21, 2022

@shuding
Khmer text is now rendering, but it's not correct. Khmer characters has font ligatures. I'm not sure how to fix it. It seems to be a problem with opentype.js?

Characters: ស + ួ + ស + ្ + ដ + ី + !
Text: សួស្ដី!

on https://opentype.js.org/

image

@seanghay
Copy link
Author

@seanghay
Copy link
Author

seanghay commented Oct 21, 2022

Btw node-canvas renders Khmer text perfectly fine. Here is an example https://github.com/seanghay/node-canvas-khmer

It looks like node-canvas is using pango layout engine.

@shuding
Copy link
Member

shuding commented Oct 21, 2022

Yeah, we don't have ligature (and some other features) and I'm not sure if that's a missing thing in opentype.js or it's a bug. Worth to look into it.

@seanghay
Copy link
Author

Someone released an another engine which supports Khmer language and many others.
chearon/dropflow#9 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants