revert: feat(eslint): update @typescript-eslint/* dependencies (#99) (

#101)
vercel · Mar 5, 2024 · 40f1c5d · 40f1c5d
1 parent ba372ab
commit 40f1c5d
Show file tree

Hide file tree

Showing 5 changed files with 63 additions and 116 deletions.
diff --git a/eslint/rules/typescript/index.js b/eslint/rules/typescript/index.js
@@ -14,14 +14,7 @@ module.exports = {
      *
      * 🔧 Fixable - https://typescript-eslint.io/rules/consistent-type-imports/
      */
-    '@typescript-eslint/consistent-type-imports': [
-      'warn',
-      {
-        disallowTypeAnnotations: true,
-        fixStyle: 'inline-type-imports',
-        prefer: 'type-imports',
-      },
-    ],
+    '@typescript-eslint/consistent-type-imports': 'warn',
     /**
      * Require explicit return types on functions and class methods.
      *

diff --git a/eslint/rules/typescript/strict.js b/eslint/rules/typescript/strict.js
@@ -0,0 +1,12 @@
+const disabledRules = {
+  // This is disabled as we feel that checking empty strings is a valid use
+  // of `||` over `??`. We'll track this related issue:
+  // https://github.com/typescript-eslint/typescript-eslint/issues/4906
+  '@typescript-eslint/prefer-nullish-coalescing': 'off',
+};
+
+module.exports = {
+  rules: {
+    ...disabledRules,
+  },
+};
diff --git a/eslint/typescript.js b/eslint/typescript.js
@@ -8,14 +8,18 @@ module.exports = {
     {
       files: TYPESCRIPT_FILES,
       extends: [
+        'plugin:@typescript-eslint/recommended',
         'plugin:@typescript-eslint/recommended-type-checked',
+        'plugin:@typescript-eslint/strict',
         'plugin:@typescript-eslint/strict-type-checked',
+        'plugin:@typescript-eslint/stylistic',
         'plugin:@typescript-eslint/stylistic-type-checked',
         'plugin:import/typescript',
         'prettier',
         require.resolve('./rules/typescript'),
         require.resolve('./rules/typescript/extension'),
         require.resolve('./rules/typescript/import'),
+        require.resolve('./rules/typescript/strict'),
         require.resolve('./rules/tsdoc'),
       ],
     },

diff --git a/package.json b/package.json
@@ -40,8 +40,8 @@
     "@babel/core": "^7.24.0",
     "@babel/eslint-parser": "^7.23.10",
     "@rushstack/eslint-patch": "^1.7.2",
-    "@typescript-eslint/eslint-plugin": "^7.1.1",
-    "@typescript-eslint/parser": "^7.1.1",
+    "@typescript-eslint/eslint-plugin": "^6.21.0",
+    "@typescript-eslint/parser": "^6.21.0",
     "eslint-config-prettier": "^9.1.0",
     "eslint-import-resolver-alias": "^1.1.2",
     "eslint-import-resolver-typescript": "^3.6.1",