polish truthy key

vercel · May 26, 2022 · 77ba3aa · 77ba3aa
1 parent 3565fdd
commit 77ba3aa
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/_internal/types.ts b/_internal/types.ts
@@ -228,7 +228,6 @@ export type KeyedMutator<Data> = (
   data?: Data | Promise<Data> | MutatorCallback<Data>,
   opts?: boolean | MutatorOptions<Data>
 ) => Promise<Data | undefined>
-// Public types
 
 export type SWRConfiguration<
   Data = any,

diff --git a/core/use-swr.ts b/core/use-swr.ts
@@ -440,9 +440,7 @@ export const useSWRHandler = <Data = any, Error = any>(
     // By using `bind` we don't need to modify the size of the rest arguments.
     // Due to https://github.com/microsoft/TypeScript/issues/37181, we have to
     // cast it to any for now.
-    async (...args) => {
-      return internalMutate<Data>(cache, keyRef.current, ...args)
-    },
+    internalMutate.bind(UNDEFINED, cache, keyRef.current) as any,
     // eslint-disable-next-line react-hooks/exhaustive-deps
     []
   )
@@ -459,9 +457,10 @@ export const useSWRHandler = <Data = any, Error = any>(
   })
 
   useIsomorphicLayoutEffect(() => {
-    if (_key && key) KEYS.add(_key)
+    const isTruthyKey = _key && key && !isFunction(_key)
+    if (isTruthyKey) KEYS.add(_key)
     return () => {
-      if (_key && key) KEYS.delete(_key)
+      if (isTruthyKey) KEYS.delete(_key)
     }
   }, [_key])