Revert "fix: remove startTransition so mutation hook could update imm…

…ediately (#2654)" (#2681)
vercel · Jun 20, 2023 · 87c6e9d · 87c6e9d
1 parent eb9444c
commit 87c6e9d
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/_internal/src/utils/state.ts b/_internal/src/utils/state.ts
@@ -1,6 +1,6 @@
 import type { MutableRefObject } from 'react'
-import { useRef, useCallback, useState } from 'react'
-import { useIsomorphicLayoutEffect } from './env'
+import React, { useRef, useCallback, useState } from 'react'
+import { useIsomorphicLayoutEffect, IS_REACT_LEGACY } from './env'
 
 /**
  * An implementation of state with dependency-tracking.
@@ -65,7 +65,11 @@ export const useStateWithDeps = <S = any>(
       }
 
       if (shouldRerender && !unmountedRef.current) {
-        rerender({})
+        if (IS_REACT_LEGACY) {
+          rerender({})
+        } else {
+          ;(React as any).startTransition(() => rerender({}))
+        }
       }
     },
     [rerender]

diff --git a/e2e/test/mutate-server-action.test.ts b/e2e/test/mutate-server-action.test.ts
@@ -1,7 +1,7 @@
 /* eslint-disable testing-library/prefer-screen-queries */
 import { test, expect } from '@playwright/test'
 
-test('mutate-server-action', async ({ page }) => {
+test.skip('mutate-server-action', async ({ page }) => {
   await page.goto('./mutate-server-action')
   await page.getByRole('button', { name: 'mutate' }).click()
   await expect(page.getByText('isMutating: true')).toBeVisible()