chore: switch to pnpm and turborepo #1983
Conversation
promer94
commented
May 19, 2022
promer94
commented
- use turbo for watch
- use turbo for build
- use turbo for type check
- use turbo for clean
- update github action setup
- update contributing guide
* use turbo for watch * use turbo for build * use turbo for type check * use turbo for clean * update github action setup * update contributing guide
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 42c3691:
|
| - uses: actions/cache@v3 | ||
| name: Setup pnpm cache | ||
| with: | ||
| path: ${{ steps.pnpm-cache.outputs.pnpm_cache_dir }} |
There was a problem hiding this comment.
Possible to get turbo cache here too?
There was a problem hiding this comment.
From turborepo discord
The problem with using action/cache is the fact that you most specify a restore key which means it will keep only one cache per build.
When you are using turborepo, this means that you have a mono-repo, which probably will produce multiple artifacts.
Think about a monorepo with A,B,C,D artifacts.
The first build will miss all, create a cache to all (the restore key will be somehow generated...) in one cache.
Then you changed only A, this build will miss, since, the previous cache contains A, and it should be missed. = no gain.
|
Thanks a lot!! |
