Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use consistent typing imports #2061

Merged
merged 1 commit into from Jun 29, 2022
Merged

Use consistent typing imports #2061

merged 1 commit into from Jun 29, 2022

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Jun 29, 2022

Fixes #2060

x-ref: #2037
x-ref: #2038

rollup-typescript plugin will output the correct types path when those imports are using import type. Adding a tslint rule to force using import type for types

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 08d871c:

Sandbox Source
SWR-Basic Configuration
SWR-States Configuration
SWR-Infinite Configuration
SWR-SSR Configuration

@huozhi huozhi marked this pull request as ready for review June 29, 2022 22:22
@huozhi huozhi requested a review from shuding as a code owner June 29, 2022 22:22
@shuding shuding merged commit 3013269 into main Jun 29, 2022
@shuding shuding deleted the fix/typing branch June 29, 2022 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type issues in 2.0.0-beta.5
2 participants