fix: make compare function only compare data (#2375) #2387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f6f5151:
|
Retrospection
force-pushed
the
main
branch
2 times, most recently
from
c77f0d7
to
6a2c0d2
Compare
|
Can we add a test for this change? |
renovate bot
added a commit
to Unleash/unleash
that referenced
this pull request
Feb 12, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [swr](https://swr.vercel.app) ([source](https://togithub.com/vercel/swr)) | [`2.0.0` -> `2.0.3`](https://renovatebot.com/diffs/npm/swr/2.0.0/2.0.3) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>vercel/swr</summary> ### [`v2.0.3`](https://togithub.com/vercel/swr/releases/tag/v2.0.3) [Compare Source](https://togithub.com/vercel/swr/compare/v2.0.2...v2.0.3) #### Patches - fix: parameters passed to subscribe is inconsistent with its declaration by [@​hong24](https://togithub.com/hong24) in [vercel/swr#2353 - fix: when inifinite key changes, should use cached pagesize instead of initialSize by [@​promer94](https://togithub.com/promer94) in [vercel/swr#2386 - fix: make compare function only compare data ([#​2375](https://togithub.com/vercel/swr/issues/2375)) by [@​Retrospection](https://togithub.com/Retrospection) and [@​promer94](https://togithub.com/promer94) in [vercel/swr#2387 [vercel/swr#2389 - fix: initial loading state should be false with revalidation is disabed by [@​promer94](https://togithub.com/promer94) in [vercel/swr#2382 - fix: Ensure hydration matches the SSR result during streaming by [@​shuding](https://togithub.com/shuding) in [vercel/swr#2391 #### Chores - ci: only run release when tags pushed by [@​promer94](https://togithub.com/promer94) in [vercel/swr#2388 - unify `-` characters in README.md by [@​JanKaifer](https://togithub.com/JanKaifer) in [vercel/swr#2334 #### New Contributors - [@​hong24](https://togithub.com/hong24) made their first contribution in [vercel/swr#2353 - [@​Retrospection](https://togithub.com/Retrospection) made their first contribution in [vercel/swr#2387 - [@​JanKaifer](https://togithub.com/JanKaifer) made their first contribution in [vercel/swr#2334 **Full Changelog**: vercel/swr@v2.0.2...v2.0.3 ### [`v2.0.2`](https://togithub.com/vercel/swr/releases/tag/v2.0.2) [Compare Source](https://togithub.com/vercel/swr/compare/v2.0.1...v2.0.2) #### Patches - fix: delay revalidation if a key is already active and has error by [@​promer94](https://togithub.com/promer94) in [vercel/swr#2338 - fix: createCacheHelper type by [@​promer94](https://togithub.com/promer94) in [vercel/swr#2365 #### Chores - release workflow by [@​huozhi](https://togithub.com/huozhi) in [vercel/swr#2374, [vercel/swr#2381, [vercel/swr#2383, [vercel/swr#2384, [vercel/swr#2385 **Full Changelog**: vercel/swr@v2.0.1...v2.0.2 ### [`v2.0.1`](https://togithub.com/vercel/swr/releases/tag/v2.0.1) [Compare Source](https://togithub.com/vercel/swr/compare/2.0.0...v2.0.1) In this patch release, we majorly improved typing support and SWR can infer the types based on the configuration. - When the `suspense` option is `true`, the returned `data` will exclude `undefined` and the `isLoading` will always be `false`. - When the `fallbackData` option is provided, the returned `data` will be the same type of `fallbackData`, and the `isLoading` will always be `false`. Here's a demo for it: https://user-images.githubusercontent.com/4800338/213288879-ffbeeeb5-aca5-4a65-8229-69fbf9b0bf70.mp4 #### What's Changed - types: make FullConfiguration generic by [@​huozhi](https://togithub.com/huozhi) in [vercel/swr#2273 - type: enforce array literal as tuple by [@​promer94](https://togithub.com/promer94) in [vercel/swr#2283 - Improve type test by [@​promer94](https://togithub.com/promer94) in [vercel/swr#2289 - update bunchee to remove the extra target cli option by [@​huozhi](https://togithub.com/huozhi) in [vercel/swr#2298 - fix: useSWRMutation should always use the latest fetcher by [@​koba04](https://togithub.com/koba04) in [vercel/swr#2290 - types: conditional swr response by [@​huozhi](https://togithub.com/huozhi) in [vercel/swr#2301 - fix: types properites in exports fields by [@​koba04](https://togithub.com/koba04) in [vercel/swr#2341 - Update license year by [@​IcedMonk](https://togithub.com/IcedMonk) in [vercel/swr#2344 - feat: add all mutate options support to useSWRInfinite by [@​koba04](https://togithub.com/koba04) in [vercel/swr#2350 - ci: add publint to check packaging on CI by [@​koba04](https://togithub.com/koba04) in [vercel/swr#2363 #### New Contributors - [@​IcedMonk](https://togithub.com/IcedMonk) made their first contribution in [vercel/swr#2344 **Full Changelog**: vercel/swr@2.0.0...v2.0.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/Unleash/unleash). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xMzAuMSIsInVwZGF0ZWRJblZlciI6IjM0LjEzMC4xIn0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #2375