test: stream ssr e2e #2395
Merged
test: stream ssr e2e #2395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c7d6955:
|
renovate bot
added a commit
to Unleash/unleash
that referenced
this pull request
Mar 9, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [swr](https://swr.vercel.app) ([source](https://togithub.com/vercel/swr)) | [`2.0.3` -> `2.0.4`](https://renovatebot.com/diffs/npm/swr/2.0.3/2.0.4) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>vercel/swr</summary> ### [`v2.0.4`](https://togithub.com/vercel/swr/releases/tag/v2.0.4) [Compare Source](https://togithub.com/vercel/swr/compare/v2.0.3...v2.0.4) #### Patches - build: fix release job condition by [@​huozhi](https://togithub.com/huozhi) in [vercel/swr#2392 - types: fix some mutation type issue by [@​promer94](https://togithub.com/promer94) in [vercel/swr#2421 - fix: Error retry should be handled by global revalidator instead of local revalidation function by [@​promer94](https://togithub.com/promer94) in [vercel/swr#2415 - fix: ensure initCache setter function stays within bounds of subscriptions by [@​lfbergee](https://togithub.com/lfbergee) in [vercel/swr#2411 #### Misc - test: stream ssr e2e by [@​promer94](https://togithub.com/promer94) in [vercel/swr#2395 - test: fix an act warning by [@​koba04](https://togithub.com/koba04) in [vercel/swr#2403 #### New Contributors - [@​lfbergee](https://togithub.com/lfbergee) made their first contribution in [vercel/swr#2411 **Full Changelog**: vercel/swr@v2.0.3...v2.0.4 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/Unleash/unleash). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xNTkuMCIsInVwZGF0ZWRJblZlciI6IjM0LjE1OS4wIn0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
kodiakhq bot
pushed a commit
to kula-app/OnLaunch
that referenced
this pull request
Mar 15, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [swr](https://swr.vercel.app) ([source](https://togithub.com/vercel/swr)) | [`2.0.3` -> `2.1.0`](https://renovatebot.com/diffs/npm/swr/2.0.3/2.1.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>vercel/swr</summary> ### [`v2.1.0`](https://togithub.com/vercel/swr/releases/tag/v2.1.0) [Compare Source](https://togithub.com/vercel/swr/compare/v2.0.4...v2.1.0) #### Feature - Subscription mode by [@​huozhi](https://togithub.com/huozhi) in [vercel/swr#1263 - parallel option for useSWRInfinite by [@​koba04](https://togithub.com/koba04) in [vercel/swr#2404 Checkout [subscription docs](https://swr.vercel.app/docs/subscription) and [useSWRInfinite parallel fetching docs](https://swr.vercel.app/docs/pagination#parallel-fetching-mode) for more details #### Patches - fix: use the latest config in useSWRMutation by [@​koba04](https://togithub.com/koba04) in [vercel/swr#2468 - Fix: type support for suspense and fallbackData([#​2396](https://togithub.com/vercel/swr/issues/2396)) by [@​taro-28](https://togithub.com/taro-28) in [vercel/swr#2452 - Error should be reset when new data comes by [@​huozhi](https://togithub.com/huozhi) in [vercel/swr#2472 - fix: avoid creating new snapshot if cache is not updated at client during streaming by [@​promer94](https://togithub.com/promer94) in [vercel/swr#2475 - refactor: initialize the cache only on first access by [@​promer94](https://togithub.com/promer94) in [vercel/swr#2479 #### Misc - ci: fix publish workflow by [@​promer94](https://togithub.com/promer94) in [vercel/swr#2453 - ci: faster e2e test by [@​promer94](https://togithub.com/promer94) in [vercel/swr#2428 - test: add a test for keepPreviousData without changing key by [@​koba04](https://togithub.com/koba04) in [vercel/swr#2470 - Always assume subscriptions will return sub count from current key by [@​huozhi](https://togithub.com/huozhi) in [vercel/swr#2460 - test: Fix flaky e2e test by [@​promer94](https://togithub.com/promer94) in [vercel/swr#2476 - chore: Add subscription example by [@​huozhi](https://togithub.com/huozhi) in [vercel/swr#2480 #### New Contributors - [@​taro-28](https://togithub.com/taro-28) made their first contribution in [vercel/swr#2452 **Full Changelog**: vercel/swr@v2.0.4...v2.1.0 ### [`v2.0.4`](https://togithub.com/vercel/swr/releases/tag/v2.0.4) [Compare Source](https://togithub.com/vercel/swr/compare/v2.0.3...v2.0.4) #### Patches - build: fix release job condition by [@​huozhi](https://togithub.com/huozhi) in [vercel/swr#2392 - types: fix some mutation type issue by [@​promer94](https://togithub.com/promer94) in [vercel/swr#2421 - fix: Error retry should be handled by global revalidator instead of local revalidation function by [@​promer94](https://togithub.com/promer94) in [vercel/swr#2415 - fix: ensure initCache setter function stays within bounds of subscriptions by [@​lfbergee](https://togithub.com/lfbergee) in [vercel/swr#2411 #### Misc - test: stream ssr e2e by [@​promer94](https://togithub.com/promer94) in [vercel/swr#2395 - test: fix an act warning by [@​koba04](https://togithub.com/koba04) in [vercel/swr#2403 #### New Contributors - [@​lfbergee](https://togithub.com/lfbergee) made their first contribution in [vercel/swr#2411 **Full Changelog**: vercel/swr@v2.0.3...v2.0.4 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/kula-app/OnLaunch). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS44LjMiLCJ1cGRhdGVkSW5WZXIiOiIzNS44LjMifQ==-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This pr intends to setup playwright for swr. So we can properly test scenario like #2391 and add more e2e test easily in the future.
Benefit
swr uses a lot of navigator specific APIs. It would be batter if we could use real browser enviorment for testing. It's more reliable then jsdom.
we dont need to worry about details like act or StrictMode in e2e test. playwright also has test generator and vscode extension to help us write tests.
playwright could provider detailed trace info for debugging or performance monitoring. It would help a lot to prevent flaky tests. It could also collect some low-level trace info for us to evaluate swr's performance.