Fix: type support for suspense and fallbackData(#2396) #2452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 21ef487:
|
taro-28
changed the title
|
Thanks for the PR, can you add some typing tests for it? |
|
I understand, I'll try it! |
|
This would be a huge fix for us! 🎉 Can we expect a swr release soon? |
connorch
added a commit
to connorch/swr
that referenced
this pull request
Mar 14, 2023
…ercel#2452)" This reverts commit 04df1bf.
kodiakhq bot
pushed a commit
to kula-app/OnLaunch
that referenced
this pull request
Mar 15, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [swr](https://swr.vercel.app) ([source](https://togithub.com/vercel/swr)) | [`2.0.3` -> `2.1.0`](https://renovatebot.com/diffs/npm/swr/2.0.3/2.1.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>vercel/swr</summary> ### [`v2.1.0`](https://togithub.com/vercel/swr/releases/tag/v2.1.0) [Compare Source](https://togithub.com/vercel/swr/compare/v2.0.4...v2.1.0) #### Feature - Subscription mode by [@​huozhi](https://togithub.com/huozhi) in [vercel/swr#1263 - parallel option for useSWRInfinite by [@​koba04](https://togithub.com/koba04) in [vercel/swr#2404 Checkout [subscription docs](https://swr.vercel.app/docs/subscription) and [useSWRInfinite parallel fetching docs](https://swr.vercel.app/docs/pagination#parallel-fetching-mode) for more details #### Patches - fix: use the latest config in useSWRMutation by [@​koba04](https://togithub.com/koba04) in [vercel/swr#2468 - Fix: type support for suspense and fallbackData([#​2396](https://togithub.com/vercel/swr/issues/2396)) by [@​taro-28](https://togithub.com/taro-28) in [vercel/swr#2452 - Error should be reset when new data comes by [@​huozhi](https://togithub.com/huozhi) in [vercel/swr#2472 - fix: avoid creating new snapshot if cache is not updated at client during streaming by [@​promer94](https://togithub.com/promer94) in [vercel/swr#2475 - refactor: initialize the cache only on first access by [@​promer94](https://togithub.com/promer94) in [vercel/swr#2479 #### Misc - ci: fix publish workflow by [@​promer94](https://togithub.com/promer94) in [vercel/swr#2453 - ci: faster e2e test by [@​promer94](https://togithub.com/promer94) in [vercel/swr#2428 - test: add a test for keepPreviousData without changing key by [@​koba04](https://togithub.com/koba04) in [vercel/swr#2470 - Always assume subscriptions will return sub count from current key by [@​huozhi](https://togithub.com/huozhi) in [vercel/swr#2460 - test: Fix flaky e2e test by [@​promer94](https://togithub.com/promer94) in [vercel/swr#2476 - chore: Add subscription example by [@​huozhi](https://togithub.com/huozhi) in [vercel/swr#2480 #### New Contributors - [@​taro-28](https://togithub.com/taro-28) made their first contribution in [vercel/swr#2452 **Full Changelog**: vercel/swr@v2.0.4...v2.1.0 ### [`v2.0.4`](https://togithub.com/vercel/swr/releases/tag/v2.0.4) [Compare Source](https://togithub.com/vercel/swr/compare/v2.0.3...v2.0.4) #### Patches - build: fix release job condition by [@​huozhi](https://togithub.com/huozhi) in [vercel/swr#2392 - types: fix some mutation type issue by [@​promer94](https://togithub.com/promer94) in [vercel/swr#2421 - fix: Error retry should be handled by global revalidator instead of local revalidation function by [@​promer94](https://togithub.com/promer94) in [vercel/swr#2415 - fix: ensure initCache setter function stays within bounds of subscriptions by [@​lfbergee](https://togithub.com/lfbergee) in [vercel/swr#2411 #### Misc - test: stream ssr e2e by [@​promer94](https://togithub.com/promer94) in [vercel/swr#2395 - test: fix an act warning by [@​koba04](https://togithub.com/koba04) in [vercel/swr#2403 #### New Contributors - [@​lfbergee](https://togithub.com/lfbergee) made their first contribution in [vercel/swr#2411 **Full Changelog**: vercel/swr@v2.0.3...v2.0.4 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/kula-app/OnLaunch). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS44LjMiLCJ1cGRhdGVkSW5WZXIiOiIzNS44LjMifQ==-->
](https://renovatebot.com){kind=link}
renovate bot
added a commit
to Unleash/unleash
that referenced
this pull request
May 4, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [swr](https://swr.vercel.app) ([source](https://togithub.com/vercel/swr)) | [`2.0.4` -> `2.1.5`](https://renovatebot.com/diffs/npm/swr/2.0.4/2.1.5) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>vercel/swr</summary> ### [`v2.1.5`](https://togithub.com/vercel/swr/releases/tag/v2.1.5) [Compare Source](https://togithub.com/vercel/swr/compare/v2.1.4...v2.1.5) #### What's Changed - fix: missing interop helpers in bundle by [@​huozhi](https://togithub.com/huozhi) in [vercel/swr#2582 **Full Changelog**: vercel/swr@v2.1.4...v2.1.5 ### [`v2.1.4`](https://togithub.com/vercel/swr/releases/tag/v2.1.4) [Compare Source](https://togithub.com/vercel/swr/compare/v2.1.3...v2.1.4) #### What's Changed - Upgrade bundler by [@​huozhi](https://togithub.com/huozhi) in [vercel/swr#2557 - examples: fix invalid links by [@​fxOne](https://togithub.com/fxOne) in [vercel/swr#2559 - types: Allow auto-import by improving generated types by [@​oosawy](https://togithub.com/oosawy) in [vercel/swr#2563 - fix: pass serialized args to preload fetcher by [@​oosawy](https://togithub.com/oosawy) in [vercel/swr#2564 - chore: use provenance for release by [@​HerringtonDarkholme](https://togithub.com/HerringtonDarkholme) in [vercel/swr#2571 - deps: update [@​testing-library/react](https://togithub.com/testing-library/react) to v14 by [@​koba04](https://togithub.com/koba04) in [vercel/swr#2578 - fix: Fix dependency tracking and useSES bug by [@​shuding](https://togithub.com/shuding) and [@​promer94](https://togithub.com/promer94) in [vercel/swr#2576 #### New Contributors - [@​fxOne](https://togithub.com/fxOne) made their first contribution in [vercel/swr#2559 - [@​oosawy](https://togithub.com/oosawy) made their first contribution in [vercel/swr#2563 - [@​HerringtonDarkholme](https://togithub.com/HerringtonDarkholme) made their first contribution in [vercel/swr#2571 **Full Changelog**: vercel/swr@v2.1.3...v2.1.4 ### [`v2.1.3`](https://togithub.com/vercel/swr/releases/tag/v2.1.3) [Compare Source](https://togithub.com/vercel/swr/compare/v2.1.2...v2.1.3) #### What's Changed - Fix [#​2548](https://togithub.com/vercel/swr/issues/2548): pass origin key to subcription callback by [@​Zheaoli](https://togithub.com/Zheaoli) in [vercel/swr#2550 - Examples: fix type in axios-typescript example by [@​daochouwangu](https://togithub.com/daochouwangu) in [vercel/swr#2552 - Update Cache Interface types by [@​dmmulroy](https://togithub.com/dmmulroy) in [vercel/swr#2554 - fix: data passed to refreshInterval function is not latest by [@​hong24](https://togithub.com/hong24) in [vercel/swr#2354 - types: allow passing function as `Data` for `useSWRSubscriptionOptions` by [@​promer94](https://togithub.com/promer94) in [vercel/swr#2551 #### New Contributors - [@​Zheaoli](https://togithub.com/Zheaoli) made their first contribution in [vercel/swr#2550 - [@​daochouwangu](https://togithub.com/daochouwangu) made their first contribution in [vercel/swr#2552 - [@​dmmulroy](https://togithub.com/dmmulroy) made their first contribution in [vercel/swr#2554 **Full Changelog**: vercel/swr@v2.1.2...v2.1.3 ### [`v2.1.2`](https://togithub.com/vercel/swr/releases/tag/v2.1.2) [Compare Source](https://togithub.com/vercel/swr/compare/v2.1.1...v2.1.2) ##### Patches - Improved type inferring for `swr/subscription` - Adding `SWRSubscriptionOptions` type for `swr/subscription` #### Changes - test: add typing test for empty config by [@​koba04](https://togithub.com/koba04) in [vercel/swr#2521 - test: fix syntax error in Equal type alias implementation by [@​SACHINnANYAKKARA](https://togithub.com/SACHINnANYAKKARA) in [vercel/swr#2517 - chore: remove engines by [@​promer94](https://togithub.com/promer94) in [vercel/swr#2536 - types: improve `useSWRSubscription` types by [@​promer94](https://togithub.com/promer94) in [vercel/swr#2535 - Rename subscription types by [@​huozhi](https://togithub.com/huozhi) in [vercel/swr#2537 #### New Contributors - [@​SACHINnANYAKKARA](https://togithub.com/SACHINnANYAKKARA) made their first contribution in [vercel/swr#2517 **Full Changelog**: vercel/swr@v2.1.1...v2.1.2 ### [`v2.1.1`](https://togithub.com/vercel/swr/releases/tag/v2.1.1) [Compare Source](https://togithub.com/vercel/swr/compare/v2.1.0...v2.1.1) #### Patches - refactor: remove useless dataRef, always compare cached data by [@​promer94](https://togithub.com/promer94) in [vercel/swr#2431 - fix: swr infers incorrect `data` type for default `SWRConfig` generic type by [@​connorch](https://togithub.com/connorch) in [vercel/swr#2506 #### Documentation - docs: update subscription example by [@​huozhi](https://togithub.com/huozhi) in [vercel/swr#2499 #### New Contributors - [@​connorch](https://togithub.com/connorch) made their first contribution in [vercel/swr#2506 **Full Changelog**: vercel/swr@v2.1.0...v2.1.1 ### [`v2.1.0`](https://togithub.com/vercel/swr/releases/tag/v2.1.0) [Compare Source](https://togithub.com/vercel/swr/compare/v2.0.4...v2.1.0) #### Feature - Subscription mode by [@​huozhi](https://togithub.com/huozhi) in [vercel/swr#1263 - parallel option for useSWRInfinite by [@​koba04](https://togithub.com/koba04) in [vercel/swr#2404 Checkout [subscription docs](https://swr.vercel.app/docs/subscription) and [useSWRInfinite parallel fetching docs](https://swr.vercel.app/docs/pagination#parallel-fetching-mode) for more details #### Patches - fix: use the latest config in useSWRMutation by [@​koba04](https://togithub.com/koba04) in [vercel/swr#2468 - Fix: type support for suspense and fallbackData([#​2396](https://togithub.com/vercel/swr/issues/2396)) by [@​taro-28](https://togithub.com/taro-28) in [vercel/swr#2452 - Error should be reset when new data comes by [@​huozhi](https://togithub.com/huozhi) in [vercel/swr#2472 - fix: avoid creating new snapshot if cache is not updated at client during streaming by [@​promer94](https://togithub.com/promer94) in [vercel/swr#2475 - refactor: initialize the cache only on first access by [@​promer94](https://togithub.com/promer94) in [vercel/swr#2479 #### Misc - ci: fix publish workflow by [@​promer94](https://togithub.com/promer94) in [vercel/swr#2453 - ci: faster e2e test by [@​promer94](https://togithub.com/promer94) in [vercel/swr#2428 - test: add a test for keepPreviousData without changing key by [@​koba04](https://togithub.com/koba04) in [vercel/swr#2470 - Always assume subscriptions will return sub count from current key by [@​huozhi](https://togithub.com/huozhi) in [vercel/swr#2460 - test: Fix flaky e2e test by [@​promer94](https://togithub.com/promer94) in [vercel/swr#2476 - chore: Add subscription example by [@​huozhi](https://togithub.com/huozhi) in [vercel/swr#2480 #### New Contributors - [@​taro-28](https://togithub.com/taro-28) made their first contribution in [vercel/swr#2452 **Full Changelog**: vercel/swr@v2.0.4...v2.1.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/Unleash/unleash). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS42OS4zIiwidXBkYXRlZEluVmVyIjoiMzUuNjkuMyIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #2396