fix(infinite): Fix the ability to use preload along with useSWRInfinite #2723
+264
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 2d867ad:
|
shuding
reviewed
Jul 26, 2023
1 task
tylersmalley
pushed a commit
to tailscale-dev/vscode-tailscale
that referenced
this pull request
Sep 11, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [swr](https://swr.vercel.app) ([source](https://togithub.com/vercel/swr)) | [`^2.2.0` -> `^2.2.2`](https://renovatebot.com/diffs/npm/swr/2.2.0/2.2.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>vercel/swr (swr)</summary> ### [`v2.2.2`](https://togithub.com/vercel/swr/releases/tag/v2.2.2) [Compare Source](https://togithub.com/vercel/swr/compare/v2.2.1...v2.2.2) #### What's Changed - fix: It should use startTransition only when IS_REACT_LEGACY is false by [@​TopGrd](https://togithub.com/TopGrd) in [vercel/swr#2756 - fix: simplify `ArgumentsTuple` by [@​Andarist](https://togithub.com/Andarist) in [vercel/swr#2761 #### New Contributors - [@​TopGrd](https://togithub.com/TopGrd) made their first contribution in [vercel/swr#2756 - [@​Andarist](https://togithub.com/Andarist) made their first contribution in [vercel/swr#2761 **Full Changelog**: vercel/swr@v2.2.1...v2.2.2 ### [`v2.2.1`](https://togithub.com/vercel/swr/releases/tag/v2.2.1) [Compare Source](https://togithub.com/vercel/swr/compare/v2.2.0...v2.2.1) #### What's Changed - Add use client directive for client components exports by [@​huozhi](https://togithub.com/huozhi) in [vercel/swr#2696 - remove the 'use client' directive and add client-only to useSWR entry. by [@​promer94](https://togithub.com/promer94) in [vercel/swr#2705 - fix: should serialize subscription fn key by [@​promer94](https://togithub.com/promer94) in [vercel/swr#2711 - build(deps-dev): bump word-wrap from 1.2.3 to 1.2.4 by [@​dependabot](https://togithub.com/dependabot) in [vercel/swr#2720 - fix: only make data and error update as a non-blocking transition by [@​promer94](https://togithub.com/promer94) in [vercel/swr#2691 - build: generate d.mts for for .mjs, so typescript could resolve types correctly by [@​promer94](https://togithub.com/promer94) in [vercel/swr#2695 - fix(infinite): Fix the ability to use preload along with useSWRInfinite by [@​agadzik](https://togithub.com/agadzik) in [vercel/swr#2723 - fix: Ensure that using preload with useSWRInfinite returns back an array of data by [@​agadzik](https://togithub.com/agadzik) in [vercel/swr#2726 - fix: preload request should be consumed within `revalidate` to support `parallel` option by [@​promer94](https://togithub.com/promer94) in [vercel/swr#2727 - Fix the issue that useSWR revalidation isn't triggered if the useSWR call happens after mutation by [@​Ponyets](https://togithub.com/Ponyets) in [vercel/swr#2731 - fix(mutate): fix types of mutate/trigger; make mutate/trigger always return the result of fetcher by [@​Ponyets](https://togithub.com/Ponyets) in [vercel/swr#2708 - build(deps-dev): bump tough-cookie from 4.1.2 to 4.1.3 by [@​dependabot](https://togithub.com/dependabot) in [vercel/swr#2735 - build(deps-dev): bump json5 from 2.2.1 to 2.2.3 by [@​dependabot](https://togithub.com/dependabot) in [vercel/swr#2736 - docs: use isLoading instead of !data by [@​pawfa](https://togithub.com/pawfa) in [vercel/swr#2734 #### New Contributors - [@​agadzik](https://togithub.com/agadzik) made their first contribution in [vercel/swr#2723 - [@​Ponyets](https://togithub.com/Ponyets) made their first contribution in [vercel/swr#2731 - [@​pawfa](https://togithub.com/pawfa) made their first contribution in [vercel/swr#2734 **Full Changelog**: vercel/swr@v2.2.0...v2.2.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 8am on monday" in timezone America/Los_Angeles, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/tailscale-dev/vscode-tailscale). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi40MC4zIiwidXBkYXRlZEluVmVyIjoiMzYuNjQuOCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovate bot
added a commit
to Unleash/unleash
that referenced
this pull request
Sep 14, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [swr](https://swr.vercel.app) ([source](https://togithub.com/vercel/swr)) | [`2.2.0` -> `2.2.2`](https://renovatebot.com/diffs/npm/swr/2.2.0/2.2.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>vercel/swr (swr)</summary> ### [`v2.2.2`](https://togithub.com/vercel/swr/releases/tag/v2.2.2) [Compare Source](https://togithub.com/vercel/swr/compare/e510955d42b472c8d45034c51b8acc12980aa2e7...4d20bff6759d4478380963654a560a1cf9ae7be1) #### What's Changed - fix: It should use startTransition only when IS_REACT_LEGACY is false by [@​TopGrd](https://togithub.com/TopGrd) in [vercel/swr#2756 - fix: simplify `ArgumentsTuple` by [@​Andarist](https://togithub.com/Andarist) in [vercel/swr#2761 #### New Contributors - [@​TopGrd](https://togithub.com/TopGrd) made their first contribution in [vercel/swr#2756 - [@​Andarist](https://togithub.com/Andarist) made their first contribution in [vercel/swr#2761 **Full Changelog**: vercel/swr@v2.2.1...v2.2.2 ### [`v2.2.1`](https://togithub.com/vercel/swr/releases/tag/v2.2.1) [Compare Source](https://togithub.com/vercel/swr/compare/024cbd106f8f1b0f8ea0006301d1a5fe974c691b...e510955d42b472c8d45034c51b8acc12980aa2e7) #### What's Changed - Add use client directive for client components exports by [@​huozhi](https://togithub.com/huozhi) in [vercel/swr#2696 - remove the 'use client' directive and add client-only to useSWR entry. by [@​promer94](https://togithub.com/promer94) in [vercel/swr#2705 - fix: should serialize subscription fn key by [@​promer94](https://togithub.com/promer94) in [vercel/swr#2711 - build(deps-dev): bump word-wrap from 1.2.3 to 1.2.4 by [@​dependabot](https://togithub.com/dependabot) in [vercel/swr#2720 - fix: only make data and error update as a non-blocking transition by [@​promer94](https://togithub.com/promer94) in [vercel/swr#2691 - build: generate d.mts for for .mjs, so typescript could resolve types correctly by [@​promer94](https://togithub.com/promer94) in [vercel/swr#2695 - fix(infinite): Fix the ability to use preload along with useSWRInfinite by [@​agadzik](https://togithub.com/agadzik) in [vercel/swr#2723 - fix: Ensure that using preload with useSWRInfinite returns back an array of data by [@​agadzik](https://togithub.com/agadzik) in [vercel/swr#2726 - fix: preload request should be consumed within `revalidate` to support `parallel` option by [@​promer94](https://togithub.com/promer94) in [vercel/swr#2727 - Fix the issue that useSWR revalidation isn't triggered if the useSWR call happens after mutation by [@​Ponyets](https://togithub.com/Ponyets) in [vercel/swr#2731 - fix(mutate): fix types of mutate/trigger; make mutate/trigger always return the result of fetcher by [@​Ponyets](https://togithub.com/Ponyets) in [vercel/swr#2708 - build(deps-dev): bump tough-cookie from 4.1.2 to 4.1.3 by [@​dependabot](https://togithub.com/dependabot) in [vercel/swr#2735 - build(deps-dev): bump json5 from 2.2.1 to 2.2.3 by [@​dependabot](https://togithub.com/dependabot) in [vercel/swr#2736 - docs: use isLoading instead of !data by [@​pawfa](https://togithub.com/pawfa) in [vercel/swr#2734 #### New Contributors - [@​agadzik](https://togithub.com/agadzik) made their first contribution in [vercel/swr#2723 - [@​Ponyets](https://togithub.com/Ponyets) made their first contribution in [vercel/swr#2731 - [@​pawfa](https://togithub.com/pawfa) made their first contribution in [vercel/swr#2734 **Full Changelog**: vercel/swr@v2.2.0...v2.2.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/Unleash/unleash). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi44My4wIiwidXBkYXRlZEluVmVyIjoiMzYuODMuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
kodiakhq bot
pushed a commit
to X-oss-byte/Vercel-ai
that referenced
this pull request
Sep 17, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [swr](https://swr.vercel.app) ([source](https://togithub.com/vercel/swr)) | [`2.2.0` -> `2.2.2`](https://renovatebot.com/diffs/npm/swr/2.2.0/2.2.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>vercel/swr (swr)</summary> ### [`v2.2.2`](https://togithub.com/vercel/swr/releases/tag/v2.2.2) [Compare Source](https://togithub.com/vercel/swr/compare/v2.2.1...v2.2.2) #### What's Changed - fix: It should use startTransition only when IS_REACT_LEGACY is false by [@​TopGrd](https://togithub.com/TopGrd) in [vercel/swr#2756 - fix: simplify `ArgumentsTuple` by [@​Andarist](https://togithub.com/Andarist) in [vercel/swr#2761 #### New Contributors - [@​TopGrd](https://togithub.com/TopGrd) made their first contribution in [vercel/swr#2756 - [@​Andarist](https://togithub.com/Andarist) made their first contribution in [vercel/swr#2761 **Full Changelog**: vercel/swr@v2.2.1...v2.2.2 ### [`v2.2.1`](https://togithub.com/vercel/swr/releases/tag/v2.2.1) [Compare Source](https://togithub.com/vercel/swr/compare/v2.2.0...v2.2.1) #### What's Changed - Add use client directive for client components exports by [@​huozhi](https://togithub.com/huozhi) in [vercel/swr#2696 - remove the 'use client' directive and add client-only to useSWR entry. by [@​promer94](https://togithub.com/promer94) in [vercel/swr#2705 - fix: should serialize subscription fn key by [@​promer94](https://togithub.com/promer94) in [vercel/swr#2711 - build(deps-dev): bump word-wrap from 1.2.3 to 1.2.4 by [@​dependabot](https://togithub.com/dependabot) in [vercel/swr#2720 - fix: only make data and error update as a non-blocking transition by [@​promer94](https://togithub.com/promer94) in [vercel/swr#2691 - build: generate d.mts for for .mjs, so typescript could resolve types correctly by [@​promer94](https://togithub.com/promer94) in [vercel/swr#2695 - fix(infinite): Fix the ability to use preload along with useSWRInfinite by [@​agadzik](https://togithub.com/agadzik) in [vercel/swr#2723 - fix: Ensure that using preload with useSWRInfinite returns back an array of data by [@​agadzik](https://togithub.com/agadzik) in [vercel/swr#2726 - fix: preload request should be consumed within `revalidate` to support `parallel` option by [@​promer94](https://togithub.com/promer94) in [vercel/swr#2727 - Fix the issue that useSWR revalidation isn't triggered if the useSWR call happens after mutation by [@​Ponyets](https://togithub.com/Ponyets) in [vercel/swr#2731 - fix(mutate): fix types of mutate/trigger; make mutate/trigger always return the result of fetcher by [@​Ponyets](https://togithub.com/Ponyets) in [vercel/swr#2708 - build(deps-dev): bump tough-cookie from 4.1.2 to 4.1.3 by [@​dependabot](https://togithub.com/dependabot) in [vercel/swr#2735 - build(deps-dev): bump json5 from 2.2.1 to 2.2.3 by [@​dependabot](https://togithub.com/dependabot) in [vercel/swr#2736 - docs: use isLoading instead of !data by [@​pawfa](https://togithub.com/pawfa) in [vercel/swr#2734 #### New Contributors - [@​agadzik](https://togithub.com/agadzik) made their first contribution in [vercel/swr#2723 - [@​Ponyets](https://togithub.com/Ponyets) made their first contribution in [vercel/swr#2731 - [@​pawfa](https://togithub.com/pawfa) made their first contribution in [vercel/swr#2734 **Full Changelog**: vercel/swr@v2.2.0...v2.2.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/sammyfilly/Vercel-ai).
tylersmalley
pushed a commit
to tailscale-dev/vscode-tailscale
that referenced
this pull request
Sep 28, 2023
](https://renovatebot.com){kind=link}
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [swr](https://swr.vercel.app) ([source](https://togithub.com/vercel/swr)) | [`^2.2.0` -> `^2.2.2`](https://renovatebot.com/diffs/npm/swr/2.2.0/2.2.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>vercel/swr (swr)</summary> ### [`v2.2.2`](https://togithub.com/vercel/swr/releases/tag/v2.2.2) [Compare Source](https://togithub.com/vercel/swr/compare/v2.2.1...v2.2.2) #### What's Changed - fix: It should use startTransition only when IS_REACT_LEGACY is false by [@​TopGrd](https://togithub.com/TopGrd) in [vercel/swr#2756 - fix: simplify `ArgumentsTuple` by [@​Andarist](https://togithub.com/Andarist) in [vercel/swr#2761 #### New Contributors - [@​TopGrd](https://togithub.com/TopGrd) made their first contribution in [vercel/swr#2756 - [@​Andarist](https://togithub.com/Andarist) made their first contribution in [vercel/swr#2761 **Full Changelog**: vercel/swr@v2.2.1...v2.2.2 ### [`v2.2.1`](https://togithub.com/vercel/swr/releases/tag/v2.2.1) [Compare Source](https://togithub.com/vercel/swr/compare/v2.2.0...v2.2.1) #### What's Changed - Add use client directive for client components exports by [@​huozhi](https://togithub.com/huozhi) in [vercel/swr#2696 - remove the 'use client' directive and add client-only to useSWR entry. by [@​promer94](https://togithub.com/promer94) in [vercel/swr#2705 - fix: should serialize subscription fn key by [@​promer94](https://togithub.com/promer94) in [vercel/swr#2711 - build(deps-dev): bump word-wrap from 1.2.3 to 1.2.4 by [@​dependabot](https://togithub.com/dependabot) in [vercel/swr#2720 - fix: only make data and error update as a non-blocking transition by [@​promer94](https://togithub.com/promer94) in [vercel/swr#2691 - build: generate d.mts for for .mjs, so typescript could resolve types correctly by [@​promer94](https://togithub.com/promer94) in [vercel/swr#2695 - fix(infinite): Fix the ability to use preload along with useSWRInfinite by [@​agadzik](https://togithub.com/agadzik) in [vercel/swr#2723 - fix: Ensure that using preload with useSWRInfinite returns back an array of data by [@​agadzik](https://togithub.com/agadzik) in [vercel/swr#2726 - fix: preload request should be consumed within `revalidate` to support `parallel` option by [@​promer94](https://togithub.com/promer94) in [vercel/swr#2727 - Fix the issue that useSWR revalidation isn't triggered if the useSWR call happens after mutation by [@​Ponyets](https://togithub.com/Ponyets) in [vercel/swr#2731 - fix(mutate): fix types of mutate/trigger; make mutate/trigger always return the result of fetcher by [@​Ponyets](https://togithub.com/Ponyets) in [vercel/swr#2708 - build(deps-dev): bump tough-cookie from 4.1.2 to 4.1.3 by [@​dependabot](https://togithub.com/dependabot) in [vercel/swr#2735 - build(deps-dev): bump json5 from 2.2.1 to 2.2.3 by [@​dependabot](https://togithub.com/dependabot) in [vercel/swr#2736 - docs: use isLoading instead of !data by [@​pawfa](https://togithub.com/pawfa) in [vercel/swr#2734 #### New Contributors - [@​agadzik](https://togithub.com/agadzik) made their first contribution in [vercel/swr#2723 - [@​Ponyets](https://togithub.com/Ponyets) made their first contribution in [vercel/swr#2731 - [@​pawfa](https://togithub.com/pawfa) made their first contribution in [vercel/swr#2734 **Full Changelog**: vercel/swr@v2.2.0...v2.2.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 8am on monday" in timezone America/Los_Angeles, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/tailscale-dev/vscode-tailscale). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi40MC4zIiwidXBkYXRlZEluVmVyIjoiMzYuNjQuOCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the use-case where I want to preload the first page of data from useSWRInfinite using the
preloadfunction fromswr.The issue was that
useSWRInfiniteprefixes the cache key's internally. Adding additional logic to the preloadmiddlewarefunction to handle the condition where the key starts with INFINITE_PREFIX as the consumer callingpreloaddoes not know about the prefix.