Skip to content

Commit

Permalink
fix: rebuild protobuf code and update ffi callsite (#4685)
Browse files Browse the repository at this point in the history
### Description

Not quite sure how this got in, but I think the generated Go protobuf
code got out of sync.
This PR is the result of `make turborepo-ffi-proto` on main and then
fixing the build error caused by trying to construct `ChangedFilesReq`
with a `*string` instead of a `string` in the `ToCommit` field

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->
  • Loading branch information
chris-olszewski committed Apr 24, 2023
1 parent 55bfd6a commit 49a9cdf
Show file tree
Hide file tree
Showing 2 changed files with 73 additions and 76 deletions.
3 changes: 1 addition & 2 deletions cli/internal/ffi/ffi.go
Expand Up @@ -118,12 +118,11 @@ func stringToRef(s string) *string {
// ChangedFiles returns the files changed in between two commits, the workdir and the index, and optionally untracked files
func ChangedFiles(gitRoot string, turboRoot string, fromCommit string, toCommit string) ([]string, error) {
fromCommitRef := stringToRef(fromCommit)
toCommitRef := stringToRef(toCommit)

req := ffi_proto.ChangedFilesReq{
GitRoot: gitRoot,
FromCommit: fromCommitRef,
ToCommit: toCommitRef,
ToCommit: toCommit,
TurboRoot: turboRoot,
}

Expand Down
146 changes: 72 additions & 74 deletions cli/internal/ffi/proto/messages.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 49a9cdf

Please sign in to comment.