Skip to content

Commit

Permalink
Remove fallback to configured git user (#4928)
Browse files Browse the repository at this point in the history
When we don't have a known CI environment variable we can rely on the
token that is used to submit the Run to associate the user. The backend
already handles this case
  • Loading branch information
mehulkar committed May 13, 2023
1 parent c1f3e66 commit 6a2da5f
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 19 deletions.
5 changes: 0 additions & 5 deletions cli/internal/runsummary/run_summary.go
Expand Up @@ -14,7 +14,6 @@ import (
"github.com/vercel/turbo/cli/internal/ci"
"github.com/vercel/turbo/cli/internal/client"
"github.com/vercel/turbo/cli/internal/env"
"github.com/vercel/turbo/cli/internal/scm"
"github.com/vercel/turbo/cli/internal/spinner"
"github.com/vercel/turbo/cli/internal/turbopath"
"github.com/vercel/turbo/cli/internal/util"
Expand Down Expand Up @@ -344,9 +343,5 @@ func getUser(envVars env.EnvironmentVariableMap, dir turbopath.AbsoluteSystemPat
username = envVars[vendor.UsernameEnvVar]
}

if username == "" {
username = scm.GetCurrentUser(dir)
}

return username
}
14 changes: 0 additions & 14 deletions cli/internal/scm/scm.go
Expand Up @@ -78,17 +78,3 @@ func GetCurrentSha(dir turbopath.AbsoluteSystemPath) string {
}
return strings.TrimRight(string(out), "\n")
}

// GetCurrentUser returns the local user.name
// We do not specify a --local or --global flag so it should
// resolve the value the same way git does when creating a commit.
func GetCurrentUser(dir turbopath.AbsoluteSystemPath) string {
cmd := exec.Command("git", []string{"config", "user.name"}...)
cmd.Dir = dir.ToString()

out, err := cmd.Output()
if err != nil {
return ""
}
return strings.TrimRight(string(out), "\n")
}

0 comments on commit 6a2da5f

Please sign in to comment.