Skip to content

Commit

Permalink
refactor(turbopack): deprecate custom_transform (#4894)
Browse files Browse the repository at this point in the history
### Description

closes WEB-1031, encourage to use consolidated ecmaplugins instead.
  • Loading branch information
kwonoj committed May 11, 2023
1 parent faabedf commit 96ab801
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 14 deletions.
10 changes: 2 additions & 8 deletions crates/turbopack/src/module_options/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,6 @@ impl ModuleOptionsVc {
ref enable_postcss_transform,
ref enable_webpack_loaders,
preset_env_versions,
ref custom_ecmascript_app_transforms,
ref custom_ecmascript_transforms,
ref custom_ecma_transform_plugins,
ref custom_rules,
execution_context,
Expand Down Expand Up @@ -114,8 +112,6 @@ impl ModuleOptionsVc {
};

let mut transforms = before_transform_plugins;
transforms.extend(custom_ecmascript_app_transforms.iter().cloned());
transforms.extend(custom_ecmascript_transforms.iter().cloned());

// Order of transforms is important. e.g. if the React transform occurs before
// Styled JSX, there won't be JSX nodes for Styled JSX to transform.
Expand Down Expand Up @@ -183,15 +179,13 @@ impl ModuleOptionsVc {
None
};

let vendor_transforms =
EcmascriptInputTransformsVc::cell(custom_ecmascript_transforms.clone());
let vendor_transforms = EcmascriptInputTransformsVc::cell(vec![]);
let ts_app_transforms = if let Some(transform) = &ts_transform {
let mut base_transforms = if let Some(decorators_transform) = &decorators_transform {
let base_transforms = if let Some(decorators_transform) = &decorators_transform {
vec![decorators_transform.clone(), transform.clone()]
} else {
vec![transform.clone()]
};
base_transforms.extend(custom_ecmascript_transforms.iter().cloned());
EcmascriptInputTransformsVc::cell(
base_transforms
.iter()
Expand Down
6 changes: 0 additions & 6 deletions crates/turbopack/src/module_options/module_options_context.rs
Original file line number Diff line number Diff line change
Expand Up @@ -157,12 +157,6 @@ pub struct ModuleOptionsContext {
pub enable_mdx_rs: bool,
#[serde(default)]
pub preset_env_versions: Option<EnvironmentVc>,
#[deprecated(note = "use custom_ecma_transform_plugins instead")]
#[serde(default)]
pub custom_ecmascript_app_transforms: Vec<EcmascriptInputTransform>,
#[deprecated(note = "use custom_ecma_transform_plugins instead")]
#[serde(default)]
pub custom_ecmascript_transforms: Vec<EcmascriptInputTransform>,
#[serde(default)]
pub custom_ecma_transform_plugins: Option<CustomEcmascriptTransformPluginsVc>,
#[serde(default)]
Expand Down

0 comments on commit 96ab801

Please sign in to comment.