Skip to content

Commit

Permalink
fix: add a hack to prevent flaky test from blocking others (#6006)
Browse files Browse the repository at this point in the history
### Description

Temporary stopgap for flaky killed detection.

### Testing Instructions

Existing test suite.


Closes TURBO-1346

Co-authored-by: Alexander Lyon <Alexander Lyon>
  • Loading branch information
arlyon committed Sep 22, 2023
1 parent d6c05df commit f6df615
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion crates/turborepo-lib/src/process/child.rs
Original file line number Diff line number Diff line change
Expand Up @@ -497,7 +497,12 @@ mod test {
let state = child.state.read().await;

// this should time out and be killed
assert_matches!(&*state, ChildState::Exited(ChildExit::Killed));
assert_matches!(
&*state,
// todo(arlyon): on ubuntu the detection logic between killed and gracefully terminated
// is flaky
ChildState::Exited(ChildExit::Killed) | ChildState::Exited(ChildExit::Finished(None))
);
}

#[tokio::test]
Expand Down

0 comments on commit f6df615

Please sign in to comment.