Fix postcss nitpicks #3077
Merged
Fix postcss nitpicks #3077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
7 Ignored Deployments
|
ForsakenHarmony
approved these changes
Dec 19, 2022
| @@ -186,12 +186,11 @@ impl Asset for PostCssTransformedAsset { | |||
| ) | |||
| .await?; | |||
| let JavaScriptValue::Value(val) = &*config_value else { | |||
| bail!("Expected a value from PostCSS transform"); | |||
There was a problem hiding this comment.
we don't want this error?
There was a problem hiding this comment.
That will lead to the same Rust stacktrace leaking out. I figure it's better to use the original CSS to allow the dev server to start up.
jridgewell
added
the
pr: automerge
sokra
reviewed
Dec 19, 2022
| @@ -191,8 +191,7 @@ | |||
| // an external module we don't provide a shim for (e.g. querystring, url). | |||
| // For now, we fail semi-silently, but in the future this should be a | |||
| // compilation error. | |||
| console.error(`Failed to load external module ${id}: ${err}`); | |||
| return undefined; | |||
| throw new Error(`Failed to load external module ${id}: ${err}`); | |||
There was a problem hiding this comment.
There might be a reason behind that. See comment. Maybe @alexkirsz knows more?
If we remove that we should also remove the comment
There was a problem hiding this comment.
I think the comment is about providing a better UX during compilation?
As for the runtime UX, it "semi-silently" fails meaning that as soon as you try to use the return value, you lose the real reason for the error happening. I think loudly failing provides a better experience.
🟢 CI successful 🟢Thanks |
Benchmark for d5e0379
Click to view full benchmark
|
jridgewell
added a commit
to vercel/next.js
that referenced
this pull request
Mar 10, 2023
Re: vercel/turbo#3065 It also fixes the gnarly stack trace error whenever the node code throws, but it doesn't look very pretty. Not sure how to handle it: <img width="1280" alt="Screen Shot 2022-12-19 at 3 46 56 PM" src="https://user-images.githubusercontent.com/112982/208519095-ec7ad539-5c23-4b95-bcc1-71ba30381e60.png">
sokra
pushed a commit
to vercel/next.js
that referenced
this pull request
Mar 13, 2023
Re: vercel/turbo#3065 It also fixes the gnarly stack trace error whenever the node code throws, but it doesn't look very pretty. Not sure how to handle it: <img width="1280" alt="Screen Shot 2022-12-19 at 3 46 56 PM" src="https://user-images.githubusercontent.com/112982/208519095-ec7ad539-5c23-4b95-bcc1-71ba30381e60.png">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: #3065
It also fixes the gnarly stack trace error whenever the node code throws, but it doesn't look very pretty. Not sure how to handle it: