Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(turborepo): Run update notifier on turbo that is actually executed #3190

Merged
merged 7 commits into from
Jan 6, 2023
Merged

fix(turborepo): Run update notifier on turbo that is actually executed #3190

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
cc9e625
Running update notifier on turbo that is actually executed
NicholasLYang Jan 5, 2023
64a499b
Switch the install command depending on global or local
NicholasLYang Jan 5, 2023
7c6b66f
Fixing tests
NicholasLYang Jan 5, 2023
406a01d
Merge branch 'main' into nicholasyang/run-update-notifier-on-last-turbo
tknickman Jan 6, 2023
142fb1d
Clippy fixes
NicholasLYang Jan 6, 2023
8e70ba4
Fixing tests
NicholasLYang Jan 6, 2023
a437a36
Merge branch 'main' into nicholasyang/run-update-notifier-on-last-turbo
tknickman Jan 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 9 additions & 2 deletions crates/turbo-updater/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,7 @@ pub fn check_for_updates(
current_version: &str,
timeout: Option<Duration>,
interval: Option<Duration>,
is_global_turbo: bool,
) -> Result<(), UpdateNotifierError> {
// bail early if the user has disabled update notifications
if should_skip_notification() {
Expand All @@ -128,6 +129,13 @@ pub fn check_for_updates(
.interval(interval);
if let Ok(Some(version)) = informer.check_version() {
let latest_version = version.to_string();
// TODO: make this package manager aware
let update_cmd = if is_global_turbo {
"npm i -g turbo".cyan().bold()
} else {
"npm i turbo".cyan().bold()
};

let msg = format!(
"
Update available {version_prefix}{current_version} ≫ {latest_version}
Expand All @@ -138,8 +146,7 @@ pub fn check_for_updates(
current_version = current_version.dimmed(),
latest_version = latest_version.green().bold(),
github_repo = github_repo,
// TODO: make this package manager aware
update_cmd = "npm i -g turbo".cyan().bold(),
update_cmd = update_cmd
);

if let Some(footer) = footer {
Expand Down