Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update swc_core to v0.72.4 #4358

Closed
wants to merge 17 commits into from
Closed

Update swc_core to v0.72.4 #4358

wants to merge 17 commits into from

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Mar 28, 2023 •
edited

Description

I expected this to make compile much faster, but I found that turbopack is using serde of AST nodes.
I'll investigate

Testing Instructions

@vercel
Copy link

vercel bot commented Mar 28, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
examples-basic-web ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 30, 2023 at 2:38PM (UTC)
examples-cra-web ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 30, 2023 at 2:38PM (UTC)
examples-designsystem-docs ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 30, 2023 at 2:38PM (UTC)
examples-gatsby-web ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 30, 2023 at 2:38PM (UTC)
examples-kitchensink-blog ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 30, 2023 at 2:38PM (UTC)
examples-native-web ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 30, 2023 at 2:38PM (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 30, 2023 at 2:38PM (UTC)
examples-svelte-web ❌ Failed (Inspect) Mar 30, 2023 at 2:38PM (UTC)
examples-tailwind-web ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 30, 2023 at 2:38PM (UTC)
examples-vite-web ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 30, 2023 at 2:38PM (UTC)
1 Ignored Deployment
Name Status Preview Comments Updated
turbo-site ⬜️ Ignored (Inspect) Mar 30, 2023 at 2:38PM (UTC)

@kdy1 kdy1 marked this pull request as ready for review March 28, 2023 01:52
@kdy1 kdy1 requested review from a team as code owners March 28, 2023 01:52
@kdy1 kdy1 requested review from mehulkar and tknickman March 28, 2023 01:52
@github-actions
Copy link
Contributor

github-actions bot commented Mar 28, 2023 •
edited

🟢 CI successful 🟢

Thanks

@sokra sokra mentioned this pull request Mar 28, 2023
Closed
sokra
sokra requested changes Mar 28, 2023
View reviewed changes
Copy link
Member

@sokra sokra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also need some changes in next.js vercel/next.js#47589

@kdy1 kdy1 requested a review from sokra March 29, 2023 05:44
@github-actions
Copy link
Contributor

✅ This changes can build next-swc

@kdy1
Copy link
Member Author

kdy1 commented Mar 29, 2023

Drafting as CI of SWC publish action failed

@kdy1 kdy1 marked this pull request as draft March 29, 2023 08:28
@mehulkar mehulkar removed their request for review March 29, 2023 20:01
@kdy1 kdy1 changed the title Update swc_core to v0.72.0 Update swc_core to v0.72.4 Mar 30, 2023
@kdy1 kdy1 marked this pull request as ready for review March 30, 2023 08:33
@kdy1 kdy1 mentioned this pull request Apr 3, 2023
Closed
1 task
@kdy1
Copy link
Member Author

kdy1 commented Apr 5, 2023

I'll create another PR to update swc_core to newer versions

@kdy1 kdy1 closed this Apr 5, 2023
@kdy1 kdy1 deleted the kdy1/swc-update branch April 5, 2023 03:45
@kdy1
Copy link
Member Author

kdy1 commented Apr 5, 2023

See #4470

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexkirsz alexkirsz alexkirsz approved these changes

@tknickman tknickman Awaiting requested review from tknickman tknickman is a code owner automatically assigned from vercel/turbo-oss

@sokra sokra Awaiting requested review from sokra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[turbopack] css source code failed: filter: alpha(opacity=100)
3 participants
@kdy1 @sokra @alexkirsz