add included metadata to chunks to allow deduplicate chunk loads at runtime #4488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Ignored Deployments
|
|
✅ This changes can build |
🟢 CI successful 🟢Thanks |
sokra
force-pushed
the
sokra/runtime-deduplication
branch
2 times, most recently
from
de335d5
to
f9a7f48
Compare
sokra
force-pushed
the
sokra/runtime-deduplication
branch
from
f9a7f48
to
648c966
Compare
sokra
force-pushed
the
sokra/runtime-deduplication
branch
from
648c966
to
07f317d
Compare
sokra
force-pushed
the
sokra/runtime-deduplication
branch
from
196e654
to
fd44600
Compare
sokra
force-pushed
the
sokra/runtime-deduplication
branch
from
fd44600
to
cd83130
Compare
sokra
force-pushed
the
sokra/runtime-deduplication
branch
from
cd83130
to
ebf8ab8
Compare
sokra
force-pushed
the
sokra/runtime-deduplication
branch
from
ebf8ab8
to
6d3aae4
Compare
Benchmark for 0ba9742Click to view benchmark
|
Benchmark for b245f99Click to view benchmark
|
alexkirsz
suggested changes
Apr 17, 2023
| loadChunk( | ||
| typeof otherChunkData === "string" | ||
| ? otherChunkData | ||
| : otherChunkData.path, |
There was a problem hiding this comment.
Should be a function getChunkPath(chunkData), we do this very often.
There was a problem hiding this comment.
It's only used once in this file
Benchmark for db28da1Click to view benchmark
|
Benchmark for 729bc00Click to view benchmark
|
alexkirsz
approved these changes
Apr 17, 2023
sokra
added a commit
to vercel/next.js
that referenced
this pull request
Apr 17, 2023
### What? * fix app dir chunking * fix app dir 404s * improve app dir performance * rerender shadowportal on errors to re-add nextjs-portal to avoid empty page * inject polyfills before user code * fix manifest generation see also vercel/turbo#4488 ### Why? App dir was very slow and lead to 404 errors ### How? add included metadata to chunks to allow deduplicate chunk loads at runtime
sokra
added a commit
that referenced
this pull request
Apr 19, 2023
### Description follow up changes from #4488
NicholasLYang
pushed a commit
to NicholasLYang/turbo
that referenced
this pull request
Apr 21, 2023
…untime (vercel#4488) ### Description Chunk loading is now more than just a single chunk filepath. It might consist of additional metadata which tells the chunk loading logic the entry modules included in this chunk. This allows the runtime logic to avoid loading chunks when all entry modules are already loaded. This means loading the same chunk from multiple sources (with different available modules) will only trigger a single load and so avoids transferring more code than needed. This is especially relevant in app dir where every client component is considers as separate chunk loading. next.js: vercel/next.js#48025
NicholasLYang
pushed a commit
to NicholasLYang/turbo
that referenced
this pull request
Apr 21, 2023
### Description follow up changes from vercel#4488
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Chunk loading is now more than just a single chunk filepath. It might consist of additional metadata which tells the chunk loading logic the entry modules included in this chunk. This allows the runtime logic to avoid loading chunks when all entry modules are already loaded.
This means loading the same chunk from multiple sources (with different available modules) will only trigger a single load and so avoids transferring more code than needed.
This is especially relevant in app dir where every client component is considers as separate chunk loading.
next.js: vercel/next.js#48025