Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete a test fixture we don't need #4558

Merged
merged 4 commits into from
Apr 13, 2023
Merged

Delete a test fixture we don't need #4558

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
70758e8
Delete a test fixture we don't need
mehulkar Apr 13, 2023
830477b
stop using fixture everywhere
mehulkar Apr 13, 2023
f7ec0a2
Combine
mehulkar Apr 13, 2023
d4cf0a7
Remove all single package flagging
mehulkar Apr 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 0 additions & 2 deletions cli/integration_tests/_fixtures/single_package_no_config/.gitignore
View file
Open in desktop

This file was deleted.

6 changes: 0 additions & 6 deletions cli/integration_tests/_fixtures/single_package_no_config/package.json
View file
Open in desktop

This file was deleted.

15 changes: 9 additions & 6 deletions cli/integration_tests/dry_json/single_package_no_config.t
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
Setup
$ . ${TESTDIR}/../_helpers/setup.sh
$ . ${TESTDIR}/../_helpers/setup_monorepo.sh $(pwd) single_package_no_config
$ . ${TESTDIR}/../_helpers/setup_monorepo.sh $(pwd) single_package
$ rm turbo.json
$ git commit -am "Delete turbo config" --quiet

$ ${TURBO} run build --dry=json
{
Expand All @@ -11,7 +13,7 @@ Setup
"rootKey": "Buffalo buffalo Buffalo buffalo buffalo buffalo Buffalo buffalo",
"files": {
"package-lock.json": "8db0df575e6509336a6719094b63eb23d2c649c1",
"package.json": "581fe2b8dcba5b03cbe51d78a973143eb6d33e3a"
"package.json": "185771929d92c3865ce06c863c07d357500d3364"
},
"hashOfExternalDependencies": "",
"rootPipeline": {
Expand All @@ -30,11 +32,12 @@ Setup
{
"taskId": "build",
"task": "build",
"hash": "c7223f212c321d3b",
"hash": "5b5ae44052e3d624",
"inputs": {
".gitignore": "38548b0538f2fc563d6bacf70dd42798c6fd9a35",
".gitignore": "6f23ff6842b5526da43ab38f4a5bf3b0158eeb42",
"package-lock.json": "8db0df575e6509336a6719094b63eb23d2c649c1",
"package.json": "581fe2b8dcba5b03cbe51d78a973143eb6d33e3a"
"package.json": "185771929d92c3865ce06c863c07d357500d3364",
"somefile.txt": "45b983be36b73c0788dc9cbcb76cbb80fc7bb057"
},
"hashOfExternalDependencies": "",
"cache": {
Expand All @@ -43,7 +46,7 @@ Setup
"status": "MISS",
"timeSaved": 0
},
"command": "echo 'building'",
"command": "echo 'building' \u003e foo",
"cliArguments": [],
"outputs": null,
"excludedOutputs": null,
Expand Down
2 changes: 1 addition & 1 deletion cli/integration_tests/single_package/dry-run.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ Setup
$ . ${TESTDIR}/../_helpers/setup_monorepo.sh $(pwd) single_package

Check
$ ${TURBO} run build --dry --single-package
$ ${TURBO} run build --dry

Global Hash Inputs
Global Files = 3
Expand Down
2 changes: 1 addition & 1 deletion cli/integration_tests/single_package/graph.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ Setup
$ . ${TESTDIR}/../_helpers/setup_monorepo.sh $(pwd) single_package

Graph
$ ${TURBO} run build --single-package --graph
$ ${TURBO} run build --graph

digraph {
\tcompound = "true" (esc)
Expand Down
15 changes: 0 additions & 15 deletions cli/integration_tests/single_package/no-config-graph.t
View file
Open in desktop

This file was deleted.

34 changes: 0 additions & 34 deletions cli/integration_tests/single_package/no-config-run.t
View file
Open in desktop

This file was deleted.

51 changes: 46 additions & 5 deletions ..._tests/single_package/no-config-dry-run.t → ...egration_tests/single_package/no-config.t
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
Setup
$ . ${TESTDIR}/../_helpers/setup.sh
$ . ${TESTDIR}/../_helpers/setup_monorepo.sh $(pwd) single_package_no_config
$ . ${TESTDIR}/../_helpers/setup_monorepo.sh $(pwd) single_package
$ rm turbo.json
$ git commit -am "Delete turbo config" --quiet

Check
$ ${TURBO} run build --dry --single-package
$ ${TURBO} run build --dry

Global Hash Inputs
Global Files = 2
Expand All @@ -14,17 +16,56 @@ Check
Tasks to Run
build
Task = build
Hash = c7223f212c321d3b
Hash = 5b5ae44052e3d624
Cached (Local) = false
Cached (Remote) = false
Command = echo 'building'
Command = echo 'building' > foo
Outputs =
Log File = .turbo/turbo-build.log
Dependencies =
Dependendents =
Inputs Files Considered = 3
Inputs Files Considered = 4
Configured Environment Variables =
Inferred Environment Variables =
Global Environment Variables = VERCEL_ANALYTICS_ID=
ResolvedTaskDefinition = {"outputs":[],"cache":false,"dependsOn":[],"inputs":[],"outputMode":"full","env":[],"persistent":false}
Framework = <NO FRAMEWORK DETECTED>

$ ${TURBO} run build --graph

digraph {
\tcompound = "true" (esc)
\tnewrank = "true" (esc)
\tsubgraph "root" { (esc)
\t\t"[root] build" -> "[root] ___ROOT___" (esc)
\t} (esc)
}

Run real once
$ ${TURBO} run build
\xe2\x80\xa2 Running build (esc)
\xe2\x80\xa2 Remote caching disabled (esc)
build: cache bypass, force executing 5b5ae44052e3d624
build:
build: > build
build: > echo 'building' > foo
build:

Tasks: 1 successful, 1 total
Cached: 0 cached, 1 total
Time:\s*[\.0-9]+m?s (re)

Run a second time, verify no caching because there is no config
$ ${TURBO} run build --single-package
\xe2\x80\xa2 Running build (esc)
\xe2\x80\xa2 Remote caching disabled (esc)
build: cache bypass, force executing 5b5ae44052e3d624
build:
build: > build
build: > echo 'building' > foo
build:

Tasks: 1 successful, 1 total
Cached: 0 cached, 1 total
Time:\s*[\.0-9]+m?s (re)

2 changes: 1 addition & 1 deletion cli/integration_tests/single_package/run.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ Setup
$ . ${TESTDIR}/../_helpers/setup_monorepo.sh $(pwd) single_package

Check
$ ${TURBO} run build --single-package
$ ${TURBO} run build
\xe2\x80\xa2 Running build (esc)
\xe2\x80\xa2 Remote caching disabled (esc)
build: cache miss, executing dd4a9a7b508b0e38
Expand Down
2 changes: 1 addition & 1 deletion cli/integration_tests/single_package/with-deps-dry-run.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ Setup
$ . ${TESTDIR}/../_helpers/setup_monorepo.sh $(pwd) single_package_deps

Check
$ ${TURBO} run test --dry --single-package
$ ${TURBO} run test --dry

Global Hash Inputs
Global Files = 2
Expand Down
2 changes: 1 addition & 1 deletion cli/integration_tests/single_package/with-deps-graph.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ Setup
$ . ${TESTDIR}/../_helpers/setup_monorepo.sh $(pwd) single_package_deps

Graph
$ ${TURBO} run test --single-package --graph
$ ${TURBO} run test --graph

digraph {
\tcompound = "true" (esc)
Expand Down
10 changes: 5 additions & 5 deletions cli/integration_tests/single_package/with-deps-run.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ Setup
$ . ${TESTDIR}/../_helpers/setup_monorepo.sh $(pwd) single_package_deps

Check
$ ${TURBO} run test --single-package
$ ${TURBO} run test
\xe2\x80\xa2 Running test (esc)
\xe2\x80\xa2 Remote caching disabled (esc)
build: cache miss, executing 8fc80cfff3b64237
Expand All @@ -22,7 +22,7 @@ Check
Time:\s*[\.0-9]+m?s (re)

Run a second time, verify caching works because there is a config
$ ${TURBO} run test --single-package
$ ${TURBO} run test
\xe2\x80\xa2 Running test (esc)
\xe2\x80\xa2 Remote caching disabled (esc)
build: cache hit, replaying output 8fc80cfff3b64237
Expand All @@ -41,7 +41,7 @@ Run a second time, verify caching works because there is a config
Time:\s*[\.0-9]+m?s >>> FULL TURBO (re)

Run with --output-logs=hash-only
$ ${TURBO} run test --single-package --output-logs=hash-only
$ ${TURBO} run test --output-logs=hash-only
\xe2\x80\xa2 Running test (esc)
\xe2\x80\xa2 Remote caching disabled (esc)
build: cache hit, suppressing output 8fc80cfff3b64237
Expand All @@ -52,7 +52,7 @@ Run with --output-logs=hash-only
Time:\s*[\.0-9]+m?s >>> FULL TURBO (re)

Run with --output-logs=errors-only
$ ${TURBO} run test --single-package --output-logs=errors-only
$ ${TURBO} run test --output-logs=errors-only
\xe2\x80\xa2 Running test (esc)
\xe2\x80\xa2 Remote caching disabled (esc)

Expand All @@ -61,7 +61,7 @@ Run with --output-logs=errors-only
Time:\s*[\.0-9]+m?s >>> FULL TURBO (re)

Run with --output-logs=none
$ ${TURBO} run test --single-package --output-logs=none
$ ${TURBO} run test --output-logs=none
\xe2\x80\xa2 Running test (esc)
\xe2\x80\xa2 Remote caching disabled (esc)

Expand Down