New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: move lockfile ffi boundary #4629
Merged
Merged
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
8c99b57
populate workspace graph serially
chris-olszewski 8d93b1e
move external deps population to method
chris-olszewski ab9f0b3
move lockfile parsing and traversal to final step
chris-olszewski f9a460c
calculate closures all at once
chris-olszewski 4f9c395
calculate all lockfiles at once in rust
chris-olszewski 31ef289
revert serial graph construction
chris-olszewski 1c6d663
minor pr feedback changes
chris-olszewski 92f0b58
switch to protobuf enum for package manager
chris-olszewski 2efd867
remove clone in favor of borrow
chris-olszewski 57be317
remove type hint
chris-olszewski 0ff9dbc
move ffi conversion logic to standard traits
chris-olszewski 1931953
Merge branch 'main' into olszewski/move_lockfile_ffi_boundary
chris-olszewski fbdeffd
Merge branch 'main' into olszewski/move_lockfile_ffi_boundary
chris-olszewski 8c6c647
fix berry test
chris-olszewski b0f20e7
add tests for verifying external hash is empty string when no lockfil…
chris-olszewski d1c52da
add tests for ensuring empty sets are different than no lockfile
chris-olszewski fada352
fix go lint
chris-olszewski 9049e5c
add go unit test on the other side of ffi
chris-olszewski File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirming understanding: this has to do a full walk because if there are floating versions the top-level deps could have not changed, but somewhere way down the tree could have.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exactly, if someone blows away the lockfile and does a fresh install all of the top level specifiers will remain the same, but what version gets installed might change.