feat(ecma-plugins): extract custom emotion transform #4662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
9 Ignored Deployments
|
|
✅ This change can build |
kwonoj
force-pushed
the
refactor-custom-transform
branch
3 times, most recently
from
c30db65
to
f9be8cc
Compare
🟢 CI successful 🟢Thanks |
kwonoj
force-pushed
the
refactor-custom-transform
branch
4 times, most recently
from
76012ad
to
7f0a798
Compare
kwonoj
changed the title
kwonoj
force-pushed
the
refactor-custom-transform
branch
2 times, most recently
from
6af81c1
to
8d6d6fe
Compare
kwonoj
force-pushed
the
refactor-custom-transform
branch
from
8d6d6fe
to
dc806f0
Compare
kwonoj
force-pushed
the
refactor-custom-transform
branch
from
dc806f0
to
5e21ec7
Compare
sokra
reviewed
Apr 26, 2023
Comment on lines
+104
to
108
| if let Some(transformer) = build_emotion_transformer(enable_emotion).await? { | ||
| transforms.push(EcmascriptInputTransform::Plugin(TransformPluginVc::cell( | ||
| transformer, | ||
| ))); | ||
| } |
There was a problem hiding this comment.
(Eventually) enable_emotion should be removed from the ModuleOptionsContext and passed as custom_ecmascript_transforms
There was a problem hiding this comment.
Yes, that makes more sense.
sokra
approved these changes
Apr 26, 2023
kwonoj
added
the
pr: automerge
sokra
pushed a commit
to vercel/next.js
that referenced
this pull request
Apr 26, 2023
<!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation or adding/fixing Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### Why? ### How? Closes NEXT- Fixes # --> ### What? This PR is necessary changes to apply vercel/turbo#4662. Need turbopack bump to make CI pass. --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
First step for WEB-940.
Context: https://vercel.slack.com/archives/C03EWR7LGEN/p1681789689115509
Currently all of the ecma transforms are explicitly listed under EcmaInputTransform in turbopack-ecmascript. This makes enum verbose, we have to manually expand it each time adding new transform, as well as turbopack-ecmascript gets larger to contain all of the 3rd party transforms by default.
PR extracts non-core transforms into a new crate, named as ecmascript-plugins then utilize EcmaInputTransform::Custom to invoke transforms instead.
EcmaInputTransform::Customis renamed toEcmaInputTransform::Pluginas well. Goal is extracting all of 3rd party / non-core transforms. This also reduces multiple steps to construct option value between caller (next-*) to actual transform (swcOptions).vercel/next.js#48671 have corresponding next.js changes.