Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix errors-only integration test #4713

Merged
merged 4 commits into from Apr 26, 2023
Merged

Fix errors-only integration test #4713

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9a3c8fd
Fix errors-only integration test
gsoltis Apr 26, 2023
1855e1f
Fix turbo_help.t
gsoltis Apr 26, 2023
30028d7
Fix one_script_error.t
gsoltis Apr 26, 2023
c4ddf3a
Merge branch 'main' into gsoltis/fix_integration_tests
mehulkar Apr 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 4 additions & 2 deletions turborepo-tests/integration/tests/errors-only.t
View file
Open in desktop
Expand Up @@ -38,7 +38,7 @@ Setup
\xe2\x80\xa2 Packages in scope: app-a (esc)
\xe2\x80\xa2 Running builderror in 1 packages (esc)
\xe2\x80\xa2 Remote caching disabled (esc)
app-a:builderror: ERROR: command finished with error: command .* npm run builderror exited \(1\) (re)
app-a:builderror: cache miss, executing e66674cd52f90ec9
app-a:builderror:
app-a:builderror: > builderror
app-a:builderror: > echo "error builderror app-a!" && exit 1
Expand All @@ -48,6 +48,7 @@ Setup
app-a:builderror: npm ERR! Error: command failed
app-a:builderror: npm ERR! in workspace: app-a
app-a:builderror: npm ERR! at location: .* (re)
app-a:builderror: ERROR: command finished with error: command .* npm run builderror exited \(1\) (re)
command .* npm run builderror exited \(1\) (re)

Tasks: 0 successful, 1 total
Expand All @@ -66,7 +67,7 @@ Setup
\xe2\x80\xa2 Packages in scope: app-a (esc)
\xe2\x80\xa2 Running builderror2 in 1 packages (esc)
\xe2\x80\xa2 Remote caching disabled (esc)
app-a:builderror2: ERROR: command finished with error: command .* npm run builderror2 exited \(1\) (re)
app-a:builderror2: cache miss, executing de9a4f19fc30bada
app-a:builderror2:
app-a:builderror2: > builderror2
app-a:builderror2: > echo "error builderror2 app-a!" && exit 1
Expand All @@ -76,6 +77,7 @@ Setup
app-a:builderror2: npm ERR! Error: command failed
app-a:builderror2: npm ERR! in workspace: app-a
app-a:builderror2: npm ERR! at location: .* (re)
app-a:builderror2: ERROR: command finished with error: command .* npm run builderror2 exited \(1\) (re)
command .* npm run builderror2 exited \(1\) (re)

Tasks: 0 successful, 1 total
Expand Down
1 change: 1 addition & 0 deletions turborepo-tests/integration/tests/one_script_error.t
View file
Open in desktop
Expand Up @@ -90,6 +90,7 @@ Make sure error code isn't swallowed with continue
my-app:okay2: > echo 'working'
my-app:okay2:
my-app:okay2: working
command \((.*)/apps/my-app\) npm run error exited \(1\) (re)

Tasks: 2 successful, 3 total
Cached: 1 cached, 3 total
Expand Down
2 changes: 2 additions & 0 deletions turborepo-tests/integration/tests/turbo_help.t
View file
Open in desktop
Expand Up @@ -137,6 +137,7 @@ Test help flag for link command
--no-gitignore Do not create or modify .gitignore (default false)
--version
--skip-infer Skip any attempts to infer which version of Turbo the project is configured to use
--target <TARGET> Specify what should be linked (default "remote cache") [default: remote-cache] [possible values: remote-cache, spaces]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For paper trail, this is from #4632.

--no-update-notifier Disable the turbo update notification
--api <API> Override the endpoint for API calls
--color Force color usage in the terminal
Expand All @@ -163,6 +164,7 @@ Test help flag for unlink command
Usage: turbo unlink [OPTIONS]

Options:
--target <TARGET> Specify what should be unlinked (default "remote cache") [default: remote-cache] [possible values: remote-cache, spaces]
--version
--skip-infer Skip any attempts to infer which version of Turbo the project is configured to use
--no-update-notifier Disable the turbo update notification
Expand Down