Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilize --env-mode #4739

Merged
merged 12 commits into from May 18, 2023
Merged

Stabilize --env-mode #4739

merged 12 commits into from May 18, 2023

Conversation

nathanhammond
Copy link
Contributor

@nathanhammond nathanhammond commented Apr 28, 2023 •
edited

This PR updates the documentation and adds a codemod for stabilizing environment variables.

@nathanhammond nathanhammond requested review from a team as code owners April 28, 2023 10:01
@turbo-orchestrator turbo-orchestrator bot added area: docs Improvements or additions to documentation pkg: turbo-codemod team: turbopack labels Apr 28, 2023
@vercel
Copy link

vercel bot commented Apr 28, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-svelte-web 🔄 Building (Inspect) May 18, 2023 0:01am
turbo-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 18, 2023 0:01am
9 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) May 18, 2023 0:01am
examples-cra-web ⬜️ Ignored (Inspect) May 18, 2023 0:01am
examples-designsystem-docs ⬜️ Ignored (Inspect) May 18, 2023 0:01am
examples-gatsby-web ⬜️ Ignored (Inspect) May 18, 2023 0:01am
examples-kitchensink-blog ⬜️ Ignored (Inspect) May 18, 2023 0:01am
examples-native-web ⬜️ Ignored (Inspect) May 18, 2023 0:01am
examples-nonmonorepo ⬜️ Ignored (Inspect) May 18, 2023 0:01am
examples-tailwind-web ⬜️ Ignored (Inspect) May 18, 2023 0:01am
examples-vite-web ⬜️ Ignored (Inspect) May 18, 2023 0:01am

@vercel
Copy link

vercel bot commented Apr 28, 2023

@nathanhammond is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

@nathanhammond nathanhammond force-pushed the stabilize-env-mode branch 3 times, most recently from 2ebc5c3 to 7f45f37 Compare April 28, 2023 12:55
mehulkar
mehulkar reviewed May 4, 2023
View reviewed changes
Copy link
Contributor

@mehulkar mehulkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been in my queue for a while, but leaving a comment and requesting that you request a re-review when it's rebased/ready (after #4788 is merged presumably). Wanted to make sure I communicated that I'm aware of this since it's been sitting open and in my queue forever

@nathanhammond nathanhammond force-pushed the stabilize-env-mode branch 2 times, most recently from 1fa3a62 to a39b658 Compare May 11, 2023 06:29
@socket-security
Copy link

socket-security bot commented May 11, 2023 •
edited

No dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

Pull request alert summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues

@nathanhammond nathanhammond mentioned this pull request May 11, 2023
Merged
@nathanhammond nathanhammond added the pr: automerge Kodiak will merge these automatically after checks pass label May 18, 2023
@kodiakhq kodiakhq bot merged commit 5c305b7 into vercel:main May 18, 2023
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mehulkar mehulkar mehulkar approved these changes

@tknickman tknickman Awaiting requested review from tknickman

@anthonyshew anthonyshew Awaiting requested review from anthonyshew anthonyshew is a code owner

Assignees
No one assigned
Labels
area: docs Improvements or additions to documentation docs: next release pkg: turbo-codemod pr: automerge Kodiak will merge these automatically after checks pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nathanhammond @mehulkar