Leave pathname formatting up to the caller #4776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 11 Ignored Deployments
|
3 tasks
|
✅ This change can build |
🟢 CI successful 🟢Thanks |
sokra
approved these changes
May 3, 2023
alexkirsz
added
the
pr: automerge
alexkirsz
added a commit
to vercel/next.js
that referenced
this pull request
May 3, 2023
See vercel/turbo#4776 This adds support for: * Default and custom global app 404 pages (`app/not-found`). * Segment-level 404 pages (`app/segment/not-found`). This also updates Turbopack: * vercel/turbo#4787 <!-- Tobias Koppers - Bugfixes for free var and binding replacement --> * vercel/turbo#4789 <!-- Alex Kirszenberg - Print a warning when importing Sass files --> * vercel/turbo#4776 <!-- Alex Kirszenberg - Leave pathname formatting up to the caller --> * vercel/turbo#4790 <!-- Tobias Koppers - remove inital compilation message by default --> ## TODO: - [ ] ~~The dev overlay shows up when `notFound()` is called, it should be hidden~~ (moved to WEB-980) - [ ] ~~Navigating to the global 404 page doesn't work~~ (this is a bug in Next.js, see NEXT-963) - [x] Tests. --------- Co-authored-by: Tobias Koppers <tobias.koppers@googlemail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Next.js code calling into
create_node_rendered_sourcedoesn't always format the pathname with a leading/.This PR removes all assumptions about the pathname from
turbopack-nodeand leaves the formatting up to the caller.Testing Instructions
N/A
Corresponding Next.js PR: vercel/next.js#49085
link WEB-366