Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow to see exports for non-enumerable properties #4783

Merged
merged 2 commits into from May 2, 2023

Conversation

sokra
Copy link
Member

@sokra sokra commented May 2, 2023

Description

enumerate all properties for namespace object creation.

This follows the webpack logic

test cases in vercel/next.js#49106

fixes WEB-976

@sokra sokra requested a review from a team as a code owner May 2, 2023 19:34
@vercel
Copy link

vercel bot commented May 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-kitchensink-blog 🔄 Building (Inspect) May 2, 2023 8:19pm
10 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) May 2, 2023 8:19pm
examples-cra-web ⬜️ Ignored (Inspect) May 2, 2023 8:19pm
examples-designsystem-docs ⬜️ Ignored (Inspect) May 2, 2023 8:19pm
examples-gatsby-web ⬜️ Ignored (Inspect) May 2, 2023 8:19pm
examples-native-web ⬜️ Ignored (Inspect) May 2, 2023 8:19pm
examples-nonmonorepo ⬜️ Ignored (Inspect) May 2, 2023 8:19pm
examples-svelte-web ⬜️ Ignored (Inspect) May 2, 2023 8:19pm
examples-tailwind-web ⬜️ Ignored (Inspect) May 2, 2023 8:19pm
examples-vite-web ⬜️ Ignored (Inspect) May 2, 2023 8:19pm
turbo-site ⬜️ Ignored (Inspect) Visit Preview May 2, 2023 8:19pm

@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2023

✅ This change can build next-swc

@sokra sokra disabled auto-merge May 2, 2023 19:44
@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2023

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@sokra sokra force-pushed the sokra/non-enumerable-exports branch from 19763cf to 06f6fd6 Compare May 2, 2023 20:19
@sokra sokra enabled auto-merge (squash) May 2, 2023 20:19
@sokra sokra merged commit 4f6069c into main May 2, 2023
40 of 41 checks passed
@sokra sokra deleted the sokra/non-enumerable-exports branch May 2, 2023 20:32
kodiakhq bot pushed a commit to vercel/next.js that referenced this pull request May 3, 2023
@sokra sokra restored the sokra/non-enumerable-exports branch May 17, 2023 15:35
@sokra sokra deleted the sokra/non-enumerable-exports branch May 17, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants