Implement package.json's imports field
#4895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To share `exports`, `imports`, and `alias` remapping
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
10 Ignored Deployments
|
|
No dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No new dependency issues detected in pull request Bot CommandsTo ignore an alert, reply with a comment starting with Pull request alert summary
|
|
✅ This change can build |
|
jridgewell
commented
May 11, 2023
| } | ||
| } | ||
|
|
||
| fn try_from(value: &Value, ty: ExportImport) -> Result<Self> { |
There was a problem hiding this comment.
In order to reuse SubpathValue parsing for imports, I needed to pass an additional ExportImport type to print the correct error messages. That prevents us from reusing the TryFrom trait. The code is otherwise the same.
There was a problem hiding this comment.
I'm a bit worried about the name.
I think someone may expect SubpathValue::try_from to be one from TryFrom, and to use v.try_into()?.
There was a problem hiding this comment.
Renamed to try_new
| @@ -115,6 +115,53 @@ async fn base_resolve_options( | |||
| let mut plugins = opt.plugins.clone(); | |||
| plugins.push(UnsupportedSassResolvePluginVc::new(root).as_resolve_plugin()); | |||
|
|
|||
| let conditions = { | |||
There was a problem hiding this comment.
Hoisted so that it can be shared for both "into" and "in" conditions. No changes.
alexkirsz
reviewed
May 11, 2023
crates/turbopack-tests/tests/snapshot/imports/subpath-imports/input/package.json
Show resolved
Hide resolved
Linux Benchmark for bd92efb
Click to view full benchmark
|
MacOS Benchmark for bd92efb
Click to view full benchmark
|
jridgewell
added
the
pr: automerge
Linux Benchmark for 527498cClick to view benchmark
|
kwonoj
approved these changes
May 18, 2023
MacOS Benchmark for 527498c
Click to view full benchmark
|
sokra
added a commit
to vercel/next.js
that referenced
this pull request
May 19, 2023
vercel/turbo#4895 renamed `ExportsValue` into `SubpathValue` --------- Co-authored-by: Tobias Koppers <tobias.koppers@googlemail.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
hydRAnger
pushed a commit
to hydRAnger/next.js
that referenced
this pull request
Jun 12, 2023
vercel/turbo#4895 renamed `ExportsValue` into `SubpathValue` --------- Co-authored-by: Tobias Koppers <tobias.koppers@googlemail.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The imports field is similar to
exports. Whileexportsallows a package to control how others can import it,importsallows it control how it wants to import other packages.The majority of the code can be shared with the already-implemented
ExportsFieldandAliasMap, with just special parsing logic. Besides that, I just needed to setup the conditional for imports and some cleanup.Testing Instructions
RUST_BACKTRACE=1 cargo nextest run -E 'test(snapshot__imports__subpath_imports)'Fixes WEB-50
Pair: vercel/next.js#49636
fix #4799