Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove fallback to configured git user #4928

Merged
merged 1 commit into from May 13, 2023
Merged

Remove fallback to configured git user #4928

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 0 additions & 5 deletions cli/internal/runsummary/run_summary.go
View file
Open in desktop
Expand Up @@ -14,7 +14,6 @@ import (
"github.com/vercel/turbo/cli/internal/ci"
"github.com/vercel/turbo/cli/internal/client"
"github.com/vercel/turbo/cli/internal/env"
"github.com/vercel/turbo/cli/internal/scm"
"github.com/vercel/turbo/cli/internal/spinner"
"github.com/vercel/turbo/cli/internal/turbopath"
"github.com/vercel/turbo/cli/internal/util"
Expand Down Expand Up @@ -344,9 +343,5 @@ func getUser(envVars env.EnvironmentVariableMap, dir turbopath.AbsoluteSystemPat
username = envVars[vendor.UsernameEnvVar]
}

if username == "" {
username = scm.GetCurrentUser(dir)
}

return username
}
14 changes: 0 additions & 14 deletions cli/internal/scm/scm.go
View file
Open in desktop
Expand Up @@ -78,17 +78,3 @@ func GetCurrentSha(dir turbopath.AbsoluteSystemPath) string {
}
return strings.TrimRight(string(out), "\n")
}

// GetCurrentUser returns the local user.name
// We do not specify a --local or --global flag so it should
// resolve the value the same way git does when creating a commit.
func GetCurrentUser(dir turbopath.AbsoluteSystemPath) string {
cmd := exec.Command("git", []string{"config", "user.name"}...)
cmd.Dir = dir.ToString()

out, err := cmd.Output()
if err != nil {
return ""
}
return strings.TrimRight(string(out), "\n")
}