Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(turbopack): deprecate single react_refresh options #4949

Merged
merged 1 commit into from
May 15, 2023

Conversation

kwonoj
Copy link
Contributor

@kwonoj kwonoj commented May 15, 2023

Description

closes WEB-1049.

vercel/next.js#49822 removes usage of the option itself, instead using jsxoptions.

@kwonoj kwonoj requested a review from a team as a code owner May 15, 2023 17:19
@vercel
Copy link

vercel bot commented May 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
turbo-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 15, 2023 5:21pm
10 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) May 15, 2023 5:21pm
examples-cra-web ⬜️ Ignored (Inspect) May 15, 2023 5:21pm
examples-designsystem-docs ⬜️ Ignored (Inspect) May 15, 2023 5:21pm
examples-gatsby-web ⬜️ Ignored (Inspect) May 15, 2023 5:21pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) May 15, 2023 5:21pm
examples-native-web ⬜️ Ignored (Inspect) May 15, 2023 5:21pm
examples-nonmonorepo ⬜️ Ignored (Inspect) May 15, 2023 5:21pm
examples-svelte-web ⬜️ Ignored (Inspect) May 15, 2023 5:21pm
examples-tailwind-web ⬜️ Ignored (Inspect) May 15, 2023 5:21pm
examples-vite-web ⬜️ Ignored (Inspect) May 15, 2023 5:21pm

@github-actions
Copy link
Contributor

✅ This change can build next-swc

@github-actions
Copy link
Contributor

github-actions bot commented May 15, 2023

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@kwonoj kwonoj added the pr: automerge Kodiak will merge these automatically after checks pass label May 15, 2023
@kodiakhq kodiakhq bot merged commit 3dd1dac into main May 15, 2023
42 of 46 checks passed
@kodiakhq kodiakhq bot deleted the deprecate-enable-refresh branch May 15, 2023 19:19
ForsakenHarmony added a commit to vercel/next.js that referenced this pull request May 16, 2023
### What?

Adds support for `mdx-components` at the root/src directory.
This is a feature `next-mdx` already has:
https://github.com/vercel/next.js/tree/canary/packages/next-mdx#usage-1

Fixes WEB-1012

Depends on vercel/turbo#4944

### Turbopack updates

* vercel/turbo#4949 <!-- OJ Kwon -
refactor(turbopack): deprecate single react_refresh options -->
* vercel/turbo#4944 <!-- Leah - add mdx
`providerImportSource` option -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: automerge Kodiak will merge these automatically after checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants