refactor(turborepo): Signature Authentication (2nd try) #4980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lgorithm (basically replace json serialization with a simple concatenation)
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Ignored Deployments
|
|
@NicholasLYang is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
arlyon
approved these changes
May 17, 2023
| } | ||
| } | ||
|
|
||
| fn secret_key(&self) -> Result<Vec<u8>, SignatureError> { |
There was a problem hiding this comment.
I believe that HMAC_SHA256 doesn't have key length requirements but a comment that verifies that would be handy.
| artifact_body: &[u8], | ||
| expected_tag: &str, | ||
| ) -> Result<bool, SignatureError> { | ||
| let secret_key = hmac::Key::new(HMAC_SHA256, &self.secret_key()?); |
There was a problem hiding this comment.
I also think we could pull HMAC_SHA256 into a constant, since it's used in more than one place. Something like TURBO_HMAC_ALGO
added 2 commits
May 18, 2023 14:26
NicholasLYang
commented
May 18, 2023
| Base64EncodingError(#[from] base64::DecodeError), | ||
| } | ||
|
|
||
| static TURBO_HMAC_ALGORITHM: Algorithm = HMAC_SHA256; |
There was a problem hiding this comment.
this is static because apparently you can't have a const that refers to another const
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactors the signature authentication to use a language-independent algorithm, as the previous implementation depended on Go's JSON serialization.
NOTE: This is a global hash bump.
Testing Instructions
Testing is using fuzzing across the Go-Rust boundary to check that signatures are correctly generated on both sides.