Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Standardize turborepo prefix #4982

Merged
merged 1 commit into from May 17, 2023

Conversation

NicholasLYang
Copy link
Contributor

@NicholasLYang NicholasLYang commented May 16, 2023

Description

To make filtering for CI and other tasks easier, we're prefixing all turborepo crates with turborepo-. That way, filtering can be done as crates/turborepo-*.

Testing Instructions

@vercel
Copy link

vercel bot commented May 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-native-web 🔄 Building (Inspect) Visit Preview May 16, 2023 5:49pm
turbo-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2023 5:49pm
9 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview May 16, 2023 5:49pm
examples-cra-web ⬜️ Ignored (Inspect) Visit Preview May 16, 2023 5:49pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview May 16, 2023 5:49pm
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview May 16, 2023 5:49pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview May 16, 2023 5:49pm
examples-nonmonorepo ⬜️ Ignored (Inspect) May 16, 2023 5:49pm
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview May 16, 2023 5:49pm
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview May 16, 2023 5:49pm
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview May 16, 2023 5:49pm

@github-actions
Copy link
Contributor

✅ This change can build next-swc

@github-actions
Copy link
Contributor

Linux Benchmark for 8d35cc5

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 9347.11µs ± 57.37µs 9389.85µs ± 80.31µs +0.46%
bench_hmr_to_eval/Turbopack CSR/1000 modules 8593.33µs ± 39.38µs 8403.02µs ± 64.41µs -2.21%
bench_startup/Turbopack CSR/1000 modules 971.41ms ± 1.38ms 963.11ms ± 3.18ms -0.85%

@github-actions
Copy link
Contributor

github-actions bot commented May 16, 2023

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)
  • Turbopack Rust benchmark tests (mac/win, non-blocking)

See workflow summary for details

@NicholasLYang NicholasLYang merged commit 717e8c3 into main May 17, 2023
70 of 73 checks passed
@NicholasLYang NicholasLYang deleted the chore/standardize-turborepo-prefix branch May 17, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants