Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(with-tailwind): support .mjs import extension #5912

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

tknickman
Copy link
Member

@tknickman tknickman commented Sep 8, 2023

Description

Fixes #5909

We're only bundling the ui package to esm, which creates an .mjs extension in dist/ which the import resolver plugin apparently(?) doesn't resolve by default.

Also, since we're linting based on TS types we need lint to depend on build.

Closes TURBO-1314

@vercel
Copy link

vercel bot commented Sep 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
examples-tailwind-web ✅ Ready (Inspect) Visit Preview Sep 8, 2023 7:20pm
10 Ignored Deployments
Name Status Preview Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Sep 8, 2023 7:20pm
examples-cra-web ⬜️ Ignored (Inspect) Sep 8, 2023 7:20pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Sep 8, 2023 7:20pm
examples-gatsby-web ⬜️ Ignored (Inspect) Sep 8, 2023 7:20pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Sep 8, 2023 7:20pm
examples-native-web ⬜️ Ignored (Inspect) Sep 8, 2023 7:20pm
examples-nonmonorepo ⬜️ Ignored (Inspect) Sep 8, 2023 7:20pm
examples-svelte-web ⬜️ Ignored (Inspect) Sep 8, 2023 7:20pm
examples-vite-web ⬜️ Ignored (Inspect) Sep 8, 2023 7:20pm
turbo-site ⬜️ Ignored (Inspect) Sep 8, 2023 7:20pm

Copy link

@orca-security-us orca-security-us bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

🟢 CI successful 🟢

Thanks

@tknickman tknickman merged commit 267f8e6 into main Sep 8, 2023
49 checks passed
@tknickman tknickman deleted the fix_examples_import_rule branch September 8, 2023 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[turborepo] - Unable to resolve any module during "turbo lint".
2 participants